[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: Panelsvg paintPanel api change
From:       "Aaron Seigo" <aseigo () kde ! org>
Date:       2008-07-26 22:11:24
Message-ID: 20080726221124.31075.54766 () vidsolbach ! de
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.vidsolbach.de/r/110/#review88
-----------------------------------------------------------

Ship it!



/trunk/KDE/kdebase/workspace/libs/plasma/panelsvg.h
<http://reviewboard.vidsolbach.de/r/110/#comment39>

    get rid of the whitespace =)



/trunk/KDE/kdebase/workspace/libs/plasma/panelsvg.h
<http://reviewboard.vidsolbach.de/r/110/#comment40>

    more whitespace


- Aaron


On 2008-07-26 13:23:58, Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.vidsolbach.de/r/110/
> -----------------------------------------------------------
> 
> (Updated 2008-07-26 13:23:58)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> this changes paintPanel(QPainter* painter, const QRectF& rect, const QPointF& pos = QPointF(0, 0));
> into
>  void paintPanel(QPainter* painter, const QRectF& target, const QRectF& source);   
> and
>  void paintPanel(QPainter* painter, const QPointF& pos = QPointF(0, 0));
> 
> to be more similat di QPainter::drawPixmap api
> 
> the old function is still jere, if it's ok, i'll remove that adapting the api accordingly (ouch :))
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/workspace/libs/plasma/panelsvg.h
>   /trunk/KDE/kdebase/workspace/libs/plasma/panelsvg.cpp
> 
> Diff: http://reviewboard.vidsolbach.de/r/110/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marco
> 
>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]