[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Adapt Device Notifier to PopupApplet
From: "=?ISO-8859-1?Q?Alexis_M=E9nard?=" <darktears31 () gmail ! com>
Date: 2008-07-26 16:42:17
Message-ID: 81941aea0807260942s765b8bf6p5c1a8ca94bbfebc () mail ! gmail ! com
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
My idea was to port the notifier to extender if it possible...i have to tak=
e
a look...
On Sat, Jul 26, 2008 at 6:48 PM, Marco Martin <notmart@gmail.com> wrote:
> On Saturday 26 July 2008, Alexis M=E9nard wrote:
> > in h file i use a Plasma::Dialog (inherits of QWidget) and i do a new
> > QWidget in desktop and a new Plasma::Dialog in taskbar...
> >
> > It's not a good way i think but there some stuff to do in plasma popup
> > applet to avoid that...Perhaps we can take a look together in
> akademy...It
> > can be done quickly...
> i think popupapplet should also have a way to make popup with graphicsvie=
ws
> (like the notifier applet, like extenders.. using extenders perhaps?)
> otherwise we wil ever only be able to do popups with plain qwidgets, a bi=
t
> limiting...
>
> Cheers,
> Marco Martin
>
> >
> > On Sat, Jul 26, 2008 at 6:33 PM, Marco Martin <notmart@gmail.com> wrote=
:
> > > On Saturday 26 July 2008, Alexis M=E9nard wrote:
> > > > In branches/work/ter-notifier, i just use dialog when the applet is
> in
> > > > a taskbar and i use a simple qwidget when the applet is in the
> > > > desktop...
> > > >
> > > > It solves the double background painting...
> > >
> > > yeah, i like that :)
> > >
> > > Cheers,
> > > Marco Martin
> > >
> > > > On Sat, Jul 26, 2008 at 6:17 PM, Marco Martin <notmart@gmail.com>
> wrote:
> > > > > -----------------------------------------------------------
> > > > > This is an automatically generated e-mail. To reply, visit:
> > > > > http://reviewboard.vidsolbach.de/r/109/#review86
> > > > > -----------------------------------------------------------
> > > > >
> > > > >
> > > > > about putting plasma::Dialog into the desktop there would be only
> one
> > > > > problem:
> > > > > this applet would be forced to have no background and
> > > > > reimplementations of popupapplet can not change its own backgroun=
d
> > > > > hints
> > > > > and on desktop the dialog svg would be displayed.
> > > > > what i would do is:
> > > > > use this patch nearly as is, but add a method (private with
> > > > > popupapplet friend?) to Plasma::dialog to disable its own
> background,
> > > > > so would
> > >
> > > still
> > >
> > > > > be popupapplet to draw the background.
> > > > > would this cause other problems?
> > > > >
> > > > > - Marco
> > > > >
> > > > > On 2008-07-26 08:56:10, Loic Marteau wrote:
> > > > > > -----------------------------------------------------------
> > > > > > This is an automatically generated e-mail. To reply, visit:
> > > > > > http://reviewboard.vidsolbach.de/r/109/
> > > > > > -----------------------------------------------------------
> > > > > >
> > > > > > (Updated 2008-07-26 08:56:10)
> > > > > >
> > > > > >
> > > > > > Review request for Plasma.
> > > > > >
> > > > > >
> > > > > > Summary
> > > > > > -------
> > > > > >
> > > > > > Here is a patch to adapt Device Notifier to use
> > > > > > Plasma::PopupApplet.
> > > > > >
> > > > > > I have add some timer stuff in popupApplet so we can say how ti=
me
> > > > > > we want
> > > > >
> > > > > popup the applet in panel.
> > > > >
> > > > > > I have change a little the way popupApplet work on Desktop mode
> by
> > > > > > using
> > > > >
> > > > > the same Plasma::dialog widget than we use in Panel Mode.
> > > > >
> > > > > > Perhaps it is not a good idea ?!
> > > > > >
> > > > > > If we prefer not using Plasma:Dialog in Desktop mode i have to
> > > > > > found
> > >
> > > a
> > >
> > > > > correct way to use the plasma theme inside the proxyWidget, which
> is
> > >
> > > not
> > >
> > > > > the case in the actual code.
> > > > >
> > > > > > Diffs
> > > > > > -----
> > > > > >
> > > > > > /trunk/KDE/kdebase/workspace/libs/plasma/popupapplet.h
> > > > > > /trunk/KDE/kdebase/workspace/libs/plasma/popupapplet.cpp
> > >
> > >
> /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicenotifier
> > >
> > > > >.h
> > >
> > >
> /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicenotifier
> > >
> > > > >.cpp
> > > > >
> > > > > > Diff: http://reviewboard.vidsolbach.de/r/109/diff
> > > > > >
> > > > > >
> > > > > > Testing
> > > > > > -------
> > > > > >
> > > > > >
> > > > > > Thanks,
> > > > > >
> > > > > > Loic
> > > > >
> > > > > _______________________________________________
> > > > > Plasma-devel mailing list
> > > > > Plasma-devel@kde.org
> > > > > https://mail.kde.org/mailman/listinfo/plasma-devel
>
>
>
[Attachment #5 (text/html)]
<div dir="ltr">My idea was to port the notifier to extender if it possible...i have \
to take a look...<br><br><div class="gmail_quote">On Sat, Jul 26, 2008 at 6:48 PM, \
Marco Martin <span dir="ltr"><<a \
href="mailto:notmart@gmail.com">notmart@gmail.com</a>></span> wrote:<br> \
<blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); \
margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"><div class="Ih2E3d">On Saturday 26 \
July 2008, Alexis Ménard wrote:<br> </div><div class="Ih2E3d">> in h file i use a \
Plasma::Dialog (inherits of QWidget) and i do a new<br> > QWidget in desktop and a \
new Plasma::Dialog in taskbar...<br> ><br>
> It's not a good way i think but there some stuff to do in plasma popup<br>
> applet to avoid that...Perhaps we can take a look together in akademy...It<br>
> can be done quickly...<br>
</div>i think popupapplet should also have a way to make popup with graphicsviews<br>
(like the notifier applet, like extenders.. using extenders perhaps?)<br>
otherwise we wil ever only be able to do popups with plain qwidgets, a bit<br>
limiting...<br>
<div><div></div><div class="Wj3C7c"><br>
Cheers,<br>
Marco Martin<br>
<br>
><br>
> On Sat, Jul 26, 2008 at 6:33 PM, Marco Martin <<a \
href="mailto:notmart@gmail.com">notmart@gmail.com</a>> wrote:<br> > > On \
Saturday 26 July 2008, Alexis Ménard wrote:<br> > > > In \
branches/work/ter-notifier, i just use dialog when the applet is in<br> > > \
> a taskbar and i use a simple qwidget when the applet is in the<br> > > \
> desktop...<br> > > ><br>
> > > It solves the double background painting...<br>
> ><br>
> > yeah, i like that :)<br>
> ><br>
> > Cheers,<br>
> > Marco Martin<br>
> ><br>
> > > On Sat, Jul 26, 2008 at 6:17 PM, Marco Martin <<a \
href="mailto:notmart@gmail.com">notmart@gmail.com</a>> wrote:<br> > > > \
> -----------------------------------------------------------<br> > > > \
> This is an automatically generated e-mail. To reply, visit:<br> > > > \
> <a href="http://reviewboard.vidsolbach.de/r/109/#review86" \
target="_blank">http://reviewboard.vidsolbach.de/r/109/#review86</a><br> > > \
> > -----------------------------------------------------------<br> > > \
> ><br> > > > ><br>
> > > > about putting plasma::Dialog into the desktop there would be only \
one<br> > > > > problem:<br>
> > > > this applet would be forced to have no background and<br>
> > > > reimplementations of popupapplet can not change its own \
background<br> > > > > hints<br>
> > > > and on desktop the dialog svg would be displayed.<br>
> > > > what i would do is:<br>
> > > > use this patch nearly as is, but add a method (private with<br>
> > > > popupapplet friend?) to Plasma::dialog to disable its own \
background,<br> > > > > so would<br>
> ><br>
> > still<br>
> ><br>
> > > > be popupapplet to draw the background.<br>
> > > > would this cause other problems?<br>
> > > ><br>
> > > > - Marco<br>
> > > ><br>
> > > > On 2008-07-26 08:56:10, Loic Marteau wrote:<br>
> > > > > \
-----------------------------------------------------------<br> > > > > \
> This is an automatically generated e-mail. To reply, visit:<br> > > > \
> > <a href="http://reviewboard.vidsolbach.de/r/109/" \
target="_blank">http://reviewboard.vidsolbach.de/r/109/</a><br> > > > > \
> -----------------------------------------------------------<br> > > > \
> ><br> > > > > > (Updated 2008-07-26 08:56:10)<br>
> > > > ><br>
> > > > ><br>
> > > > > Review request for Plasma.<br>
> > > > ><br>
> > > > ><br>
> > > > > Summary<br>
> > > > > -------<br>
> > > > ><br>
> > > > > Here is a patch to adapt Device Notifier to use<br>
> > > > > Plasma::PopupApplet.<br>
> > > > ><br>
> > > > > I have add some timer stuff in popupApplet so we can say how \
time<br> > > > > > we want<br>
> > > ><br>
> > > > popup the applet in panel.<br>
> > > ><br>
> > > > > I have change a little the way popupApplet work on Desktop \
mode by<br> > > > > > using<br>
> > > ><br>
> > > > the same Plasma::dialog widget than we use in Panel Mode.<br>
> > > ><br>
> > > > > Perhaps it is not a good idea ?!<br>
> > > > ><br>
> > > > > If we prefer not using Plasma:Dialog in Desktop mode i have \
to<br> > > > > > found<br>
> ><br>
> > a<br>
> ><br>
> > > > correct way to use the plasma theme inside the proxyWidget, which \
is<br> > ><br>
> > not<br>
> ><br>
> > > > the case in the actual code.<br>
> > > ><br>
> > > > > Diffs<br>
> > > > > -----<br>
> > > > ><br>
> > > > > \
/trunk/KDE/kdebase/workspace/libs/plasma/popupapplet.h<br> > > > > > \
/trunk/KDE/kdebase/workspace/libs/plasma/popupapplet.cpp<br> > ><br>
> > /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicenotifier<br>
> ><br>
> > > >.h<br>
> ><br>
> > /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicenotifier<br>
> ><br>
> > > >.cpp<br>
> > > ><br>
> > > > > Diff: <a href="http://reviewboard.vidsolbach.de/r/109/diff" \
target="_blank">http://reviewboard.vidsolbach.de/r/109/diff</a><br> > > > \
> ><br> > > > > ><br>
> > > > > Testing<br>
> > > > > -------<br>
> > > > ><br>
> > > > ><br>
> > > > > Thanks,<br>
> > > > ><br>
> > > > > Loic<br>
> > > ><br>
> > > > _______________________________________________<br>
> > > > Plasma-devel mailing list<br>
> > > > <a \
href="mailto:Plasma-devel@kde.org">Plasma-devel@kde.org</a><br> > > > > \
<a href="https://mail.kde.org/mailman/listinfo/plasma-devel" \
target="_blank">https://mail.kde.org/mailman/listinfo/plasma-devel</a><br> <br>
<br>
</div></div></blockquote></div><br></div>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic