[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Review Request: Adapt Device Notifier to PopupApplet
From:       "Loic Marteau" <loic.marteau () gmail ! com>
Date:       2008-07-26 15:56:10
Message-ID: 20080726155610.24889.87447 () vidsolbach ! de
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.vidsolbach.de/r/109/
-----------------------------------------------------------

Review request for Plasma.


Summary
-------

Here is a patch to adapt Device Notifier to use Plasma::PopupApplet.

I have add some timer stuff in popupApplet so we can say how time we want popup the \
applet in panel.

I have change a little the way popupApplet work on Desktop mode by using the same \
Plasma::dialog widget than we use in Panel Mode. Perhaps it is not a good idea ?!

If we prefer not using Plasma:Dialog in Desktop mode i have to found a correct way to \
use the plasma theme inside the proxyWidget, which is not the case in the actual \
code.


Diffs
-----

  /trunk/KDE/kdebase/workspace/libs/plasma/popupapplet.h
  /trunk/KDE/kdebase/workspace/libs/plasma/popupapplet.cpp
  /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicenotifier.h
  /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicenotifier.cpp

Diff: http://reviewboard.vidsolbach.de/r/109/diff


Testing
-------


Thanks,

Loic

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[prev in list] [next in list] [prev in thread] [next in thread]