[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: [PATCH] Don't show tooltips after a click
From:       "=?ISO-8859-1?Q?Alexis_M=E9nard?=" <darktears31 () gmail ! com>
Date:       2008-07-25 17:30:11
Message-ID: 81941aea0807251030r6583efd5q33bdd8e8f831bb43 () mail ! gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


Ok for me

2008/7/25 Aaron J. Seigo <aseigo@kde.org>:

> On Friday 25 July 2008, Jason Stubbs wrote:
> > On Saturday 26 July 2008 00:22:08 JST, Jason Stubbs wrote:
> > > On Friday 25 July 2008 23:53:29 JST, Alex Merry wrote:
> > > > On Friday 25 July 2008 15:36:27 Jason Stubbs wrote:
> > > > > Hey,
> > > > >
> > > > > Just a quickie so going direct to the ML.
> > > > >
> > > > > Basically, having a tooltip pop up after moving the mouse into the
> > > > > tasks and clicking a task to switch to it is really bugging me.
> This
> > > > > patch fixes it (and cleans up a little whitespace too). Okay to
> > > > > commit?
> > > >
> > > > Please do!  It's driving me bats.
> > >
> > > Done. For some reason, it doesn't fix the Icon applet. Nothing looks
> > > strange code-wise though... Will have a closer look.
> >
> > The icon widget (a child of the icon applet) handles clicks, moves, etc
> so
> > the event never reaches the icon applet and is thus not filterable by the
> > tooltip manager. This patch changes the tooltip registration to the icon
> > widget.
>
> sounds good.
>
> > Unless! The tooltip manager should be smart enough to filter child
> widgets
> > (and watch for new children) as well? I personally think it's more
> trouble
> > than it's worth, but it'd be the better way to go if it is possible
> without
> > much effort.
>
> no, this will cause other problems (e.g. if ther are different tooltips on
> different children)
>
> --
> Aaron J. Seigo
> humru othro a kohnu se
> GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43
>
> KDE core developer sponsored by Trolltech
>
>
> _______________________________________________
> Plasma-devel mailing list
> Plasma-devel@kde.org
> https://mail.kde.org/mailman/listinfo/plasma-devel
>
>

[Attachment #5 (text/html)]

<div dir="ltr">Ok for me<br><br><div class="gmail_quote">2008/7/25 Aaron J. Seigo \
&lt;<a href="mailto:aseigo@kde.org">aseigo@kde.org</a>&gt;:<br><blockquote \
class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt \
0pt 0.8ex; padding-left: 1ex;"> <div class="Ih2E3d">On Friday 25 July 2008, Jason \
Stubbs wrote:<br> &gt; On Saturday 26 July 2008 00:22:08 JST, Jason Stubbs wrote:<br>
&gt; &gt; On Friday 25 July 2008 23:53:29 JST, Alex Merry wrote:<br>
&gt; &gt; &gt; On Friday 25 July 2008 15:36:27 Jason Stubbs wrote:<br>
&gt; &gt; &gt; &gt; Hey,<br>
&gt; &gt; &gt; &gt;<br>
&gt; &gt; &gt; &gt; Just a quickie so going direct to the ML.<br>
&gt; &gt; &gt; &gt;<br>
&gt; &gt; &gt; &gt; Basically, having a tooltip pop up after moving the mouse into \
the<br> &gt; &gt; &gt; &gt; tasks and clicking a task to switch to it is really \
bugging me. This<br> &gt; &gt; &gt; &gt; patch fixes it (and cleans up a little \
whitespace too). Okay to<br> &gt; &gt; &gt; &gt; commit?<br>
&gt; &gt; &gt;<br>
&gt; &gt; &gt; Please do! &nbsp;It&#39;s driving me bats.<br>
&gt; &gt;<br>
&gt; &gt; Done. For some reason, it doesn&#39;t fix the Icon applet. Nothing \
looks<br> &gt; &gt; strange code-wise though... Will have a closer look.<br>
&gt;<br>
&gt; The icon widget (a child of the icon applet) handles clicks, moves, etc so<br>
&gt; the event never reaches the icon applet and is thus not filterable by the<br>
&gt; tooltip manager. This patch changes the tooltip registration to the icon<br>
&gt; widget.<br>
<br>
</div>sounds good.<br>
<div class="Ih2E3d"><br>
&gt; Unless! The tooltip manager should be smart enough to filter child widgets<br>
&gt; (and watch for new children) as well? I personally think it&#39;s more \
trouble<br> &gt; than it&#39;s worth, but it&#39;d be the better way to go if it is \
possible without<br> &gt; much effort.<br>
<br>
</div>no, this will cause other problems (e.g. if ther are different tooltips on<br>
different children)<br>
<font color="#888888"><br>
--<br>
Aaron J. Seigo<br>
humru othro a kohnu se<br>
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA &nbsp;EE75 D6B7 2EB1 A7F1 DB43<br>
<br>
KDE core developer sponsored by Trolltech<br>
<br>
</font><br>_______________________________________________<br>
Plasma-devel mailing list<br>
<a href="mailto:Plasma-devel@kde.org">Plasma-devel@kde.org</a><br>
<a href="https://mail.kde.org/mailman/listinfo/plasma-devel" \
target="_blank">https://mail.kde.org/mailman/listinfo/plasma-devel</a><br> \
<br></blockquote></div><br></div>



_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic