[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: [PATCH] Picture navigation for the frame plasmoid
From:       "Aaron J. Seigo" <aseigo () kde ! org>
Date:       2008-07-16 0:38:51
Message-ID: 200807151838.54955.aseigo () kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


On Tuesday 15 July 2008, Éric ALBER wrote:
> Tell me what you think about that :)

Frame::hoverEnterEvent should probably call Applet::hoverEnterEvent.

you may want to use Plasm::PaintUtils::shadowText in createTextPixmap instead 
of drawing your own text.

stylistically, getNextImage and getPrevImage should probably be nextImage and 
prevImage.

should size() on this line:

     m_displayPreviousLabel = event->pos().x() < size().width() / 2;

be contentsRect().size()?

otherwise it looks ok from here, though i'll let annma obviously have the last 
say and signoff =)

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Trolltech


["signature.asc" (application/pgp-signature)]

_______________________________________________
Panel-devel mailing list
Panel-devel@kde.org
https://mail.kde.org/mailman/listinfo/panel-devel


[prev in list] [next in list] [prev in thread] [next in thread]