From kde-panel-devel  Sat Jun 14 22:54:21 2008
From: Rafael =?iso-8859-15?q?Fern=E1ndez_L=F3pez?= <ereslibre () kde ! org>
Date: Sat, 14 Jun 2008 22:54:21 +0000
To: kde-panel-devel
Subject: Re: Patch for system tray layouting
Message-Id: <200806150054.24215.ereslibre () kde ! org>
X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=121348412728206
MIME-Version: 1
Content-Type: multipart/mixed; boundary="--===============1815795149=="

--===============1815795149==
Content-Type: multipart/signed;
  boundary="nextPart1305820.lpWkO6rzAn";
  protocol="application/pgp-signature";
  micalg=pgp-sha1
Content-Transfer-Encoding: 7bit

--nextPart1305820.lpWkO6rzAn
Content-Type: text/plain;
  charset="iso-8859-15"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline

Hi,

Actually, a real patch would work. A real patch helps people who are not th=
e=20
author but can give feedback by reading the rest of the code (like me) to g=
ive=20
a hand.

What I can tell, and is in relation to what Bernhard said is: really guys, =
if=20
we ever go mobile, we will just cry because of all those hard coded values =
we=20
will have to change. For this sizes, instead of a pretty hard coded value=20
(22), use, please, KIconLoader::SizeSmallMedium.

If we ever go mobile, we can do SizeSmallMedium =3D 11 and all our icons wi=
ll be=20
smaller, without the need of changing hard coded values everywhere.

However, the logic of the (patch?) makes sense for me.

Next time, please, do a "svn diff", which will be much better for review,=20
rather than posting directly code on your message :)


Regards,
Rafael Fern=E1ndez L=F3pez.

--nextPart1305820.lpWkO6rzAn
Content-Type: application/pgp-signature; name=signature.asc 
Content-Description: This is a digitally signed message part.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)

iD8DBQBIVEwgck5Abj8B0HARAsO2AJ93UZosBlw3+SLm9EuIq48wlyOfhQCbBzSU
6XXbpjOd48KwM2fUER44x3c=
=7/nD
-----END PGP SIGNATURE-----

--nextPart1305820.lpWkO6rzAn--

--===============1815795149==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Panel-devel mailing list
Panel-devel@kde.org
https://mail.kde.org/mailman/listinfo/panel-devel

--===============1815795149==--