[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: patch for Containment config
From:       Marco Martin <notmart () gmail ! com>
Date:       2008-05-21 21:43:53
Message-ID: 200805212343.53394.notmart () gmail ! com
[Download RAW message or body]

On Wednesday 21 May 2008, Aaron J. Seigo wrote:
> hi..
>
> (not using review board because it seems to be, once again, fubar)
>
> the attached patch does three things:
>
> * switches use from KConfigGroup* to KConfigGroup&
>
> * consolidates save/load/restore in Applet and Containment into one set of
> virtual methods (as well as settle on restore instead of load everywhere)
>
> * introduces Containment::saveContents and restoreContents

hmm, i know it kinda sucks as a review but i can't see particular problems in 
it, +1 i would say

Cheers,
Marco Martin

> the point of this (besides the API cleanliness) is to allow Containments to
> have fine grained control of their save/restore process. this will allow
> runtime containments that do not get saved as part of the layout, for
> example (needed by the notification applet) as well open the doors for
> containments that just don't follow the usual Applet pattern.
>
> this is really a flaw in the API design, requires a BIC change and thus i
> consider it a bug fix.
>
> for the existing codebase it is life as usual; this simply opens new doors
> where they are needed. please review and comment; i'd like to commit soon.


_______________________________________________
Panel-devel mailing list
Panel-devel@kde.org
https://mail.kde.org/mailman/listinfo/panel-devel
[prev in list] [next in list] [prev in thread] [next in thread]