[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: [REVIEW] Improved applet drag&drop support
From:       "Riccardo Iaconelli" <riccardo () kde ! org>
Date:       2008-05-11 10:03:18
Message-ID: f57cdca40805110303o39dc7447l7abc6fa56a090db5 () mail ! gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

[Attachment #4 (text/plain)]

2008/5/10 Rob Scheepmaker <r.scheepmaker@student.utwente.nl>:

> On Sat, May 10, 2008 at 07:19:20PM +0200, Rob Scheepmaker wrote:
> > Hi,
>

Hi!


>
> >
> > I've improved my drag&drop patch some more. This patch tries to improve
>
> Maybe I should include the patch... :s
>  <https://mail.kde.org/mailman/listinfo/panel-devel>
>

I've not tried it, but the patch *looks* good to me.
Just a single nitpick:

* applet.h: "The view wher e" -> typo =)

And a suggestion:

* applethandle.cpp: //TODO: is there a window flag to make this not appear
in the task manager?
  I'm sure there is something, yakuake does it. maybe ask Sho or have a look
at the codebase?

For the rest it looks pretty well written, unless I'm on crack. =)

Bye,
-Riccardo
-- 
GPG key:
3D0F6376
When encrypting, please encrypt also for this subkey:
9EBD7FE1
-----
Pace Peace Paix Paz Frieden Pax Pokój Friður Fred Béke 和平
Hasiti Lapé Hetep Malu Mир Wolakota Santiphap Irini Peoch שלום
Shanti Vrede Baris Rój Mír Taika Rongo Sulh Mir Py'guapy 평화

[Attachment #5 (text/html)]

2008/5/10 Rob Scheepmaker &lt;<a \
href="mailto:r.scheepmaker@student.utwente.nl">r.scheepmaker@student.utwente.nl</a>&gt;:<br><div \
class="gmail_quote"><blockquote class="gmail_quote" style="border-left: 1px solid \
rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"> <div \
class="Ih2E3d">On Sat, May 10, 2008 at 07:19:20PM +0200, Rob Scheepmaker wrote:<br> \
&gt; Hi,</div></blockquote><div><br>Hi!<br>&nbsp;</div><blockquote \
class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt \
0pt 0.8ex; padding-left: 1ex;"><div class="Ih2E3d"><br> &gt;<br>
&gt; I&#39;ve improved my drag&amp;drop patch some more. This patch tries to \
improve<br> <br>
</div>Maybe I should include the patch... :s<br>
<a href="https://mail.kde.org/mailman/listinfo/panel-devel" \
target="_blank"></a><br></blockquote></div><br>I&#39;ve not tried it, but the patch \
*looks* good to me.<br>Just a single nitpick:<br><br>* applet.h: &quot;The view wher \
e&quot; -&gt; typo =)<br clear="all"> <br>And a suggestion:<br><br>* \
applethandle.cpp: //TODO: is there a window flag to make this not appear in the task \
manager?<br>&nbsp; I&#39;m sure there is something, yakuake does it. maybe ask Sho or \
have a look at the codebase?<br> <br>For the rest it looks pretty well written, \
unless I&#39;m on crack. =)<br><br>Bye,<br>-Riccardo<br>-- <br>GPG \
key:<br>3D0F6376<br>When encrypting, please encrypt also for this \
subkey:<br>9EBD7FE1<br>-----<br>Pace Peace Paix Paz Frieden Pax Pokój Friður Fred \
Béke 和平<br> Hasiti Lapé Hetep Malu Mир Wolakota Santiphap Irini Peoch \
שלום<br>Shanti Vrede Baris Rój Mír Taika Rongo Sulh Mir Py&#39;guapy 평화



_______________________________________________
Panel-devel mailing list
Panel-devel@kde.org
https://mail.kde.org/mailman/listinfo/panel-devel


[prev in list] [next in list] [prev in thread] [next in thread]