[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: [PATCH] 1 root-widget per xinerama/mergedfb/xrandr-screen
From: "Aaron J. Seigo" <aseigo () kde ! org>
Date: 2008-04-30 19:18:17
Message-ID: 200804301318.17427.aseigo () kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/signed)]
On Wednesday 30 April 2008, Aike J Sommer wrote:
> The attached patch will make plasma(-the-app) use one root-widget per
> screen, thus working around intels 2048px texture-size limit.
cool.
> This relies on another patch to kwin to allow desktop-windows to only cover
> 1 screen instead of everything, i sent that to the kwinlist.
hm. does this work with other window manager as well?
> This basically makes RootWidget not a real widget anymore (should we rename
> it then?)
actually, i think this can go one step further: move all the management code
into PlasmaApp so that it manages both the panel views as well as the desktop
views and get rid of RootWidget all together.
this would likely end up looking like this:
Moved to PlasmaApp:
* toggleDashboard
* setAsDesktop (should be setIsDesktop)
* isDesktop would all move to PlasmaApp
* createDesktopView merges into PlasmaApp::createView
Moved to DesktopView
* screenOwnerChanged; connect directly to the corona, don't do any of this
from PlasmaApp anymore
Removed as uneeded:
* viewForScreen
> and uses DesktopView as the real root-widgets...
cool; note that with your patch DesktopViews are now being leaked. they have
no parent object anymore, and aren't deleted in the RootWidget dtor. they
should be deleted so that if any clean up code gets put into ~DesktopView it
will get run on shutdown.
--
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43
KDE core developer sponsored by Trolltech
["signature.asc" (application/pgp-signature)]
_______________________________________________
Panel-devel mailing list
Panel-devel@kde.org
https://mail.kde.org/mailman/listinfo/panel-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic