[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: [PATCH] RunnerManager
From:       "Aaron J. Seigo" <aseigo () kde ! org>
Date:       2008-04-22 17:51:32
Message-ID: 200804221151.32575.aseigo () kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


On Tuesday 22 April 2008, Ryan P. Bitanga wrote:
> 2008/4/22 Aaron J. Seigo <aseigo@kde.org>:
> > On Tuesday 22 April 2008, Ryan P. Bitanga wrote:
> >  > IMHO we shouldn't be using heuristic algorithms for controlling the
> >  > speed or priority lists for that matter. threadweaver has a priority
> >  > queue of its own.
> >
> >  and how exactly will threadweaver know which thread to give priority to?
> > i agree that using QueuePolicy is a better approach, but we'll still need
> > to implement whatever directs canRun
>
> I understand the reasons you wrote the rate-limiting heuristic but I
> disagree in the implementation. Obviously there needs to be logic to
> direct the ordering of the execution of runners as you pointed out but
> IMO that would best be accomplished by calling setPriority.

sure ... i think we generally agree on this point; but it's all moot until 
there's something more than "slow" and "not slow", and we'll still need some 
heuristic to measure these things by.

> I'll see 
> if I recommend a better approach within the next few weeks. :) But I

ok =)

> must say your rate-limiting modifications got me thinking of taking a
> page from Ingo Molnar's book and using a rb-tree, except that seemed
> too heavyweight. Other scheduling approaches come to my mind but I am
> loathe to add complexity to KRunner. 

yes, i went for a dead simple approach for this precise reason.

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Trolltech

["signature.asc" (application/pgp-signature)]

_______________________________________________
Panel-devel mailing list
Panel-devel@kde.org
https://mail.kde.org/mailman/listinfo/panel-devel


[prev in list] [next in list] [prev in thread] [next in thread]