[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: Making panel toolbox to do something
From:       Marco Martin <notmart () gmail ! com>
Date:       2008-04-22 11:36:31
Message-ID: 20080422113631.17336.71262 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://mattr.info/r/326/
-----------------------------------------------------------

(Updated 2008-04-22 06:36:31.750053)


Review request for Plasma.


Summary
-------

This patch adds a new class called PanelController that is a QGraphicsWidget that \
will contain stuff for the panel configuration, at the moment it contains add widgets \
and remove panel, there is a very early implementation of panel resizing by drag and \
drop. i kinda prefer a separate class instead of putting directly into the toolbox


Diffs
-----

  /trunk/KDE/kdebase/workspace/libs/plasma/CMakeLists.txt
  /trunk/KDE/kdebase/workspace/libs/plasma/containment.h
  /trunk/KDE/kdebase/workspace/libs/plasma/containment.cpp
  /trunk/KDE/kdebase/workspace/libs/plasma/panelcontroller.cpp
  /trunk/KDE/kdebase/workspace/libs/plasma/panelcontroller_p.h
  /trunk/KDE/kdebase/workspace/libs/plasma/toolbox.cpp
  /trunk/KDE/kdebase/workspace/libs/plasma/toolbox_p.h

Diff: http://mattr.info/r/326/diff


Testing
-------

still has some problems, i consider this patch to still be an early draft :(
no support to vertical panels at all
the panel resize handle doesn't work properly in many ways (still to be decided how \
it should behave btw)  when dragging it the scaling and position seems quite \
flickering random  the view size it's not updated (i guess i'll have to export \
panelcontroller and connect from panelview or modyfying the view from panel \
controller or something like that)  at the moment the view is scaled (or at least \
should be) only when the mouse is released, i fear that rescaling/repositioning the \
view from every mouse movement would be heavy and flickering? removing panels \
produces crashes (seems to crash anyways)


Thanks,

Marco

_______________________________________________
Panel-devel mailing list
Panel-devel@kde.org
https://mail.kde.org/mailman/listinfo/panel-devel


[prev in list] [next in list] [prev in thread] [next in thread]