[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: eject icons on devicenotifier
From:       Marco Martin <notmart () gmail ! com>
Date:       2008-03-13 18:18:00
Message-ID: 20080313181800.8596.34473 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://mattr.info/r/285/
-----------------------------------------------------------

(Updated 2008-03-13 13:18:00.620403)


Review request for Plasma.


Summary
-------

This patch adds a little eject icon to the right of mounted volumes in the device notifier. \
clicking on it ejects optical discs and unmounts other removable devices. additionally the \
devices icons now have the usual mounted overlays.


This addresses bug 158936.


Diffs
-----

  /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicenotifier.h
  /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicenotifier.cpp
  /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/itemdelegate.h
  /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/itemdelegate.cpp
  /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/notifierview.h
  /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/notifierview.cpp

Diff: http://mattr.info/r/285/diff


Testing
-------

tried to unmount eject some dvds/thumbdrives.
tried also with the --reverse command line switch it puts the eject column on the left.


Screenshots
-----------

some discs mounted
  http://mattr.info/r/285/s/34/


Thanks,

Marco

_______________________________________________
Panel-devel mailing list
Panel-devel@kde.org
https://mail.kde.org/mailman/listinfo/panel-devel


[prev in list] [next in list] [prev in thread] [next in thread]