[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: Animates tabswitching
From:       Mehdi Salem Naraghi <momesana () googlemail ! com>
Date:       2008-03-10 16:20:56
Message-ID: 20080310162056.21432.50671 () localhost
[Download RAW message or body]



> On 2008-03-10 10:00:07, Marco Martin wrote:
> > i think it looks good, both in code and visually
> 
> Will Stephenson wrote:
> Can we hold off committing this?  I found it too slow, and frankly, redundant to \
> have an animation here at all. 
> Mehdi Salem Naraghi wrote:
> Well the speed of the animation can be increased but I must admit that it feels \
> slower than the animation done using the QTimeLine. I did however use 150ms in both \
> situations so its probably a Phase issue. It's just a perception though and I might \
> be wrong.

Btw, I think the animation looks good and is not redundant at all.


- Mehdi


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://mattr.info/r/278/#review278
-----------------------------------------------------------


On 2008-03-09 07:11:19, Mehdi Salem Naraghi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://mattr.info/r/278/
> -----------------------------------------------------------
> 
> (Updated 2008-03-09 07:11:19)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> Adds a nice transition animation during a tabswitch . The code now uses \
> Phase::customAnimation() instead of the former QTimeLine. 
> 
> Diffs
> -----
> 
> trunk/KDE/kdebase/workspace/plasma/applets/kickoff/ui/tabbar.h
> trunk/KDE/kdebase/workspace/plasma/applets/kickoff/ui/tabbar.cpp
> 
> Diff: http://mattr.info/r/278/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Mehdi
> 
> 

_______________________________________________
Panel-devel mailing list
Panel-devel@kde.org
https://mail.kde.org/mailman/listinfo/panel-devel


[prev in list] [next in list] [prev in thread] [next in thread]