[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: properly remove m_size var from panel code [sorry
From:       Chani Armitage <chanika () gmail ! com>
Date:       2008-02-29 18:11:30
Message-ID: 20080229181130.21887.12674 () localhost
[Download RAW message or body]



> On 2008-02-29 09:42:07, Aaron Seigo wrote:
> > /trunk/KDE/kdebase/workspace/plasma/containments/panel/panel.cpp, lines 442-443
> > <http://mattr.info/r/219/diff/2/#file692line442>
> > 
> > that's a bit of an odd comment since the first thing setGeometry does is call setPos.
> > 
> > in what way was it confusing the view?
> > 
> > was the size() changing as well in this process?
> 
> Chani Armitage wrote:
> by "confuses" I mean "the view doesn't notice anything has changed". no, size() was not \
> changing. /me looks at the setGeometry code...
> oh, it must be that update() down at the bottom. maybe I just need to call that, really, \
> instead of all this updatePos insanity. er, but I have a feeling I'm not really supposed to \
> call update() from constraintsUpdated() - why do I have that feeling?

no, update() doesn't work after all. this means that something *else* is magically alerting the \
view. which makes no sense, because there should not be any other code triggered. I'm too tired \
to make sense of it tonight.


- Chani


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://mattr.info/r/219/#review216
-----------------------------------------------------------


On 2008-02-29 12:06:36, Chani Armitage wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://mattr.info/r/219/
> -----------------------------------------------------------
> 
> (Updated 2008-02-29 12:06:36)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> this completely removes m_size. I introduced a few functions to keep things clear. there is a \
> small change in behaviour - the config dialog now shows the full size of the panel, including \
> the borders. this might horribly break with multiple screens, I'm not sure. please test.
> 
> 
> Diffs
> -----
> 
> /trunk/KDE/kdebase/workspace/plasma/containments/panel/panel.h
> /trunk/KDE/kdebase/workspace/plasma/containments/panel/panel.cpp
> 
> Diff: http://mattr.info/r/219/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Chani
> 
> 

_______________________________________________
Panel-devel mailing list
Panel-devel@kde.org
https://mail.kde.org/mailman/listinfo/panel-devel


[prev in list] [next in list] [prev in thread] [next in thread]