[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Plasma::Phase proposal
From:       "Aaron J. Seigo" <aseigo () kde ! org>
Date:       2008-01-31 4:13:15
Message-ID: 200801302113.15463.aseigo () kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


> So I tried to connect the signal Plasma::Phase::animationComplete in
> order to zero the ids and then
> paint the background mormally, but I found that animationComplete
> wasn't been emitted for
> element animations.

when progress == 1 you know the animation is complete.

> Proposal:
> - All animations (Item, Movement, Element, Custom) will return an animation
> id - All animations can be stopped using the given id
> - All animations will receive animationComplete signal when completed
> and the id as argument of the signal

this is probably a good idea, yes.

> If you approve I will implement the necessary changes

looks fine. when you have a patch ready, maybe you coulld pop it up on 
matt.rogers.name and we can see how review-board works for us =)

(p.s. would've been nicer as a diff so it was immediately visible what the 
exact changes were)

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Trolltech

["signature.asc" (application/pgp-signature)]

_______________________________________________
Panel-devel mailing list
Panel-devel@kde.org
https://mail.kde.org/mailman/listinfo/panel-devel


[prev in list] [next in list] [prev in thread] [next in thread]