[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: [PATCH] Fifteen puzzle config revamp
From:       "Andre Magalhaes" <andrunko () gmail ! com>
Date:       2008-01-22 19:44:34
Message-ID: 7b3e4da90801221144p28313724vfe1b00f97e990cc3 () mail ! gmail ! com
[Download RAW message or body]

2008/1/22 Chani <chanika@gmail.com>:
>
> +    while (m_pieces.at(rand) != NULL) {
> +      rand = qrand() % 16;
> +    }
>
> this... looks... Bad.
> I hate seeing any loop that has a random ending condition... what if it never
> finishes?
> but I don't know the context, and it's past my bedtime so I'm just gonna skip
> down to... oh! you already used configNeedsSaving() - awesome. :)
>
Yeah, I don't like this also, but this is not my code, and I didn't
touch it (besides
reindent it).
I tried to just fix the config dialog, and add the possibility to save
the config options.
Maybe this can be discussed with the applet "owner".

BR

-- 
Andre Moreira Magalhaes (andrunko)
--------------------------------------------------------
Jabber: andrunko@gmail.com
MSN:   andremoreira@msn.com
Skype:  andrunko
Blog:    http://andrunko.blogspot.com
_______________________________________________
Panel-devel mailing list
Panel-devel@kde.org
https://mail.kde.org/mailman/listinfo/panel-devel
[prev in list] [next in list] [prev in thread] [next in thread]