[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: [PATCH] Fifteen puzzle config revamp
From:       Chani <chanika () gmail ! com>
Date:       2008-01-22 19:27:39
Message-ID: 200801230327.50781.chanika () gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


+    while (m_pieces.at(rand) != NULL) {
+      rand = qrand() % 16;
+    }

this... looks... Bad.
I hate seeing any loop that has a random ending condition... what if it never 
finishes?
but I don't know the context, and it's past my bedtime so I'm just gonna skip 
down to... oh! you already used configNeedsSaving() - awesome. :)

-- 
This message brought to you by evyl bananas, and the number 3.
www.chani3.com

["signature.asc" (application/pgp-signature)]

_______________________________________________
Panel-devel mailing list
Panel-devel@kde.org
https://mail.kde.org/mailman/listinfo/panel-devel


[prev in list] [next in list] [prev in thread] [next in thread]