[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    [PATCH] Icon tooltips
From:       Marco Martin <notmart () gmail ! com>
Date:       2008-01-09 20:12:05
Message-ID: 200801092112.05672.notmart () gmail ! com
[Download RAW message or body]

Hi,
i was thinking about putting tooltips into icons (but only on panel, because 
it doesn't says much more than the icon text)
a thing that should be done would be putting a global seeting to turn on/of 
tooltips in taskbar, icons and all the other places, don't think it makes 
much sense to put the setting applet wise
how does it looks like?

Cheers,
Marco Martin

["icon_tooltip.diff" (text/x-diff)]

Index: /opt/svn/kdebase/workspace/plasma/applets/icon/icon.cpp
===================================================================
--- /opt/svn/kdebase/workspace/plasma/applets/icon/icon.cpp	(revision 758846)
+++ /opt/svn/kdebase/workspace/plasma/applets/icon/icon.cpp	(working copy)
@@ -96,6 +96,8 @@
             m_text = m_url.fileName();
         }
         m_icon->setIcon(f->readIcon());
+
+        data.subText = f->readGenericName();
     } else {
         m_text = m_url.fileName();
         m_icon->setIcon(KMimeType::iconNameForUrl(url));
@@ -104,6 +106,9 @@
     if (m_icon->icon().isNull()) {
         m_icon->setIcon("unknown");
     }
+
+    data.mainText = m_text;
+    data.image = m_icon->icon().pixmap(48);
 }
 
 void IconApplet::openUrl()
@@ -125,9 +130,11 @@
             formFactor() == Plasma::MediaCenter) {
             m_icon->setText(m_text);
             setMinimumContentSize(m_icon->sizeFromIconSize(IconSize(KIconLoader::Desktop)));
+            m_icon->setToolTip(Plasma::ToolTipData());
         } else {
             m_icon->setText(QString());
             setMinimumContentSize(m_icon->sizeFromIconSize(IconSize(KIconLoader::Panel)));
+            m_icon->setToolTip(data);
         }
     }
 
Index: /opt/svn/kdebase/workspace/plasma/applets/icon/icon.h
===================================================================
--- /opt/svn/kdebase/workspace/plasma/applets/icon/icon.h	(revision 758846)
+++ /opt/svn/kdebase/workspace/plasma/applets/icon/icon.h	(working copy)
@@ -72,6 +72,7 @@
         void connectMouseSlots();
 
         Plasma::Icon* m_icon;
+        Plasma::ToolTipData data;
         QString m_text;
         KPropertiesDialog *m_dialog;
         QString m_mimetype;


_______________________________________________
Panel-devel mailing list
Panel-devel@kde.org
https://mail.kde.org/mailman/listinfo/panel-devel


[prev in list] [next in list] [prev in thread] [next in thread]