From kde-panel-devel Mon Dec 31 21:08:18 2007 From: "Maksim Orlovich" Date: Mon, 31 Dec 2007 21:08:18 +0000 To: kde-panel-devel Subject: [Panel-devel] [PATCH] Don't leak timers in taskbar Message-Id: <1829.74.39.37.145.1199135298.squirrel () webmail ! cornell ! edu> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=119913535015658 MIME-Version: 1 Content-Type: multipart/mixed; boundary="------=_20071231160818_32539" ------=_20071231160818_32539 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 8bit Hi... The plasma taskbar currently (as of the revision I have on my laptop, anyway) seems to leak some timers, which shows up in CPU use eventually climbing. The attached should fix at least one cause of that: startTimer w/o killTimer. If you look at QObject::startTimer docs, it's not single-shot, so single-shot use needs an explicit kill. Anyway, if this is OK, it'd be good if someone committed... I don't have good net access at the moment, so I might not be able to -Maks ------=_20071231160818_32539 Content-Type: application/octet-stream; name="plasma_timers.diff" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="plasma_timers.diff" ZGlmZiAtLWdpdCBhL3dvcmtzcGFjZS9wbGFzbWEvYXBwbGV0cy90YXNrcy9hYnN0cmFjdHRhc2tp dGVtLmNwcCBiL3dvcmtzcGFjZS9wbGFzbWEvYXBwbGV0cy90YXNrcy9hYnN0cmFjdHRhc2tpdGVt LmNwcAppbmRleCAzYjYxZTc1Li5jMmZkOTFmIDEwMDY0NAotLS0gYS93b3Jrc3BhY2UvcGxhc21h L2FwcGxldHMvdGFza3MvYWJzdHJhY3R0YXNraXRlbS5jcHAKKysrIGIvd29ya3NwYWNlL3BsYXNt YS9hcHBsZXRzL3Rhc2tzL2Fic3RyYWN0dGFza2l0ZW0uY3BwCkBAIC0xMDMsNiArMTAzLDcgQEAg dm9pZCBBYnN0cmFjdFRhc2tJdGVtOjpxdWV1ZVVwZGF0ZSgpCiB2b2lkIEFic3RyYWN0VGFza0l0 ZW06OnRpbWVyRXZlbnQoUVRpbWVyRXZlbnQgKmV2ZW50KQogewogICAgIGlmIChldmVudC0+dGlt ZXJJZCgpID09IG1fdXBkYXRlVGltZXJJZCkgeworICAgICAgICBraWxsVGltZXIobV91cGRhdGVU aW1lcklkKTsKICAgICAgICAgdXBkYXRlKCk7CiAgICAgICAgIG1fdXBkYXRlVGltZXJJZCA9IC0x OwogICAgIH0KZGlmZiAtLWdpdCBhL3dvcmtzcGFjZS9wbGFzbWEvYXBwbGV0cy90YXNrcy90YXNr Z3JvdXBpdGVtLmNwcCBiL3dvcmtzcGFjZS9wbGFzbWEvYXBwbGV0cy90YXNrcy90YXNrZ3JvdXBp dGVtLmNwcAppbmRleCBhNWUxZWQyLi44YTUxNTFmIDEwMDY0NAotLS0gYS93b3Jrc3BhY2UvcGxh c21hL2FwcGxldHMvdGFza3MvdGFza2dyb3VwaXRlbS5jcHAKKysrIGIvd29ya3NwYWNlL3BsYXNt YS9hcHBsZXRzL3Rhc2tzL3Rhc2tncm91cGl0ZW0uY3BwCkBAIC0yODksNiArMjg5LDcgQEAgdm9p ZCBUYXNrR3JvdXBJdGVtOjpxdWV1ZUdlb21ldHJ5VXBkYXRlKCkKIHZvaWQgVGFza0dyb3VwSXRl bTo6dGltZXJFdmVudChRVGltZXJFdmVudCAqZXZlbnQpCiB7CiAgICAgaWYgKGV2ZW50LT50aW1l cklkKCkgPT0gbV9nZW9tZXRyeVVwZGF0ZVRpbWVySWQpIHsKKyAgICAgICAga2lsbFRpbWVyKG1f Z2VvbWV0cnlVcGRhdGVUaW1lcklkKTsKICAgICAgICAgdXBkYXRlR2VvbWV0cnkoKTsKICAgICAg ICAgbV9nZW9tZXRyeVVwZGF0ZVRpbWVySWQgPSAtMTsKICAgICB9Cg== ------=_20071231160818_32539 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Panel-devel mailing list Panel-devel@kde.org https://mail.kde.org/mailman/listinfo/panel-devel ------=_20071231160818_32539--