------=_Part_22138_31436027.1199130723040 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline Well I included it because I was getting a 1px icon instead of the actual image by not using setMinimum, not sure if it's a bug with Plasma::Icon, but the way I see it's better to limit the icon from being a size other than we intended :). Here's my latest patch that plays with the gradient. And some screenshot love :D Closed: http://img185.imageshack.us/my.php?image=tool1uj5.png Expanded: http://img185.imageshack.us/my.php?image=tool2rr7.png And this is my current desktop shot of kde4. http://home.cfl.rr.com/gamma/images/ss.png Great work Oxygen folks! :D On 12/28/07, Alex Merry wrote: > On Fri, Dec 28, 2007 at 05:32:23PM +0900, Jason Stubbs wrote: > > One tiny nit-picky thing so no need to repost a patch, but: > > > > + tool->setMinimumSize(iconSize); > > + tool->setMaximumSize(iconSize); > > + tool->resize(tool->sizeHint()); > > > > Is there any reason to not use iconSize rather than tool->sizeHint() ? I'm > > guessing that it returns the same value anyway, but looks out of place and > > begs the eternal question "why is it so?" ;) > > Actually, tool->sizeHint() for Plasma::Icon returns the last value > passed to tool->resize(). My approach was to do > tool->resize(tool->sizeFromIconSize(iconSize)); > > That should work as a replacement for the above three lines. I think > setMinimumSize and setMaximumSize can be discarded, as there's no > layouts doing anything. > > Alex > > -- > KDE: http://www.kde.org > OpenSUSE: http://www.opensuse.org > ------=_Part_22138_31436027.1199130723040 Content-Type: text/x-patch; name=icons-123007.patch Content-Transfer-Encoding: base64 X-Attachment-Id: file0 Content-Disposition: attachment; filename=icons-123007.patch SW5kZXg6IGRlc2t0b3B0b29sYm94LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBkZXNrdG9wdG9vbGJveC5j cHAJKHJldmlzaW9uIDc1NDc1NikKKysrIGRlc2t0b3B0b29sYm94LmNwcAkod29ya2luZyBjb3B5 KQpAQCAtMzUsNyArMzUsNyBAQAogCiBEZXNrdG9wVG9vbGJveDo6RGVza3RvcFRvb2xib3goUUdy YXBoaWNzSXRlbSAqcGFyZW50KQogICAgIDogUUdyYXBoaWNzSXRlbShwYXJlbnQpLAotICAgICAg bV9pY29uKCJjb25maWd1cmUiKSwKKyAgICAgIG1faWNvbigicGxhc21hIiksCiAgICAgICBtX3Np emUoNTApLAogICAgICAgbV9zaG93aW5nKGZhbHNlKSwKICAgICAgIG1fYW5pbUlkKDApLApAQCAt NjcsOCArNjcsOSBAQAogICAgIFFQYWludGVyUGF0aCBwID0gc2hhcGUoKTsKICAgICBRUmFkaWFs R3JhZGllbnQgZ3JhZGllbnQoUVBvaW50KG1fc2l6ZSoyLCAwKSwgbV9zaXplKjMpOwogICAgIGdy YWRpZW50LnNldEZvY2FsUG9pbnQoUVBvaW50RihtX3NpemUqMiwgMCkpOwotICAgIGdyYWRpZW50 LnNldENvbG9yQXQoMCwgUUNvbG9yKDI1NSwgMjU1LCAyNTUsIDEyOCkpOwotICAgIGdyYWRpZW50 LnNldENvbG9yQXQoLjksIFFDb2xvcigxMjgsIDEyOCwgMTI4LCAxMjgpKTsKKyAgICBncmFkaWVu dC5zZXRDb2xvckF0KDAsIFFDb2xvcigyNTUsIDI1NSwgMjU1LCA5NikpOworICAgIGdyYWRpZW50 LnNldENvbG9yQXQoLjMzLCBRQ29sb3IoMTI4LCAxMjgsIDEyOCwgOTYpKTsKKyAgICBncmFkaWVu dC5zZXRDb2xvckF0KC42NiwgUUNvbG9yKDEyOCwgMTI4LCAxMjgsIDApKTsKICAgICBwYWludGVy LT5zYXZlKCk7CiAgICAgcGFpbnRlci0+c2V0UGVuKFF0OjpOb1Blbik7CiAgICAgcGFpbnRlci0+ c2V0UmVuZGVySGludChRUGFpbnRlcjo6QW50aWFsaWFzaW5nLCB0cnVlKTsKSW5kZXg6IGNvbnRh aW5tZW50LmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gY29udGFpbm1lbnQuaAkocmV2aXNpb24gNzU0NzU2KQor KysgY29udGFpbm1lbnQuaAkod29ya2luZyBjb3B5KQpAQCAtMzAsNiArMzAsOCBAQAogI2luY2x1 ZGUgPHBsYXNtYS9hcHBsZXQuaD4KICNpbmNsdWRlIDxwbGFzbWEvcGhhc2UuaD4KIAorI2luY2x1 ZGUgIndpZGdldHMvaWNvbi5oIgorCiBuYW1lc3BhY2UgUGxhc21hCiB7CiAKQEAgLTIxNCw5ICsy MTYsMTUgQEAKICAgICAgICAgdm9pZCBlbWl0TGF1bmNoQWN0aXZhdGVkKCk7CiAKICAgICAgICAg LyoqCi0gICAgICAgICAqIEFkZHMgYW4gaXRlbSB0byB0aGUgdG9vbGJveC4gVGhlIHRvb2xib3gg dGFrZXMgb3ZlciBvd25lcnNoaXAgb2YgdGhlIGl0ZW0uCisgICAgICAgICAqIENvbnN0cnVjdHMg YSB0b29sYm94IGl0ZW0gYW5kIGFkZHMgaXQgdG8gdGhlIHRvb2xib3guIFRoZSB0b29sYm94IHRh a2VzIG92ZXIgb3duZXJzaGlwIG9mIHRoZSBpdGVtLiBSZXR1cm5zIHRoZSBjb25zdHJ1Y3RlZCB0 b29sLgorICAgICAgICAgKiAKKyAgICAgICAgICogQGFyZyBuYW1lIG9mIHRoZSB0b29sCisgICAg ICAgICAqIEBhcmcgbmFtZSBvZiB0aGUgaWNvbgorICAgICAgICAgKiBAYXJnIHRleHQgdG8gYmUg ZGlzcGxheWVkIG9uIHRoZSBpY29uCisgICAgICAgICAqCisgICAgICAgICAqIEByZXR1cm4gdGhl IGNvbnN0cnVjdGVkIHRvb2wKICAgICAgICAgICovCi0gICAgICAgIHZvaWQgYWRkVG9vbEJveFRv b2woUUdyYXBoaWNzSXRlbSAqdG9vbCwgY29uc3QgUVN0cmluZyAmdG9vbG5hbWUgPSBRU3RyaW5n KCkpOworICAgICAgICBQbGFzbWE6Okljb24gKiBhZGRUb29sQm94VG9vbChjb25zdCBRU3RyaW5n ICZ0b29sTmFtZSA9IFFTdHJpbmcoKSwgY29uc3QgUVN0cmluZyAmaWNvbk5hbWUgPSBRU3RyaW5n KCksIGNvbnN0IFFTdHJpbmcgJmljb25UZXh0ID0gUVN0cmluZygpKTsKIAogICAgICAgICAvKioK ICAgICAgICAgICogRW5hYmxlcyBvciBkaXNhYmxlcyBhIHRvb2xib3ggdG9vbCBieSBuYW1lCklu ZGV4OiBjb250YWlubWVudC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gY29udGFpbm1lbnQuY3BwCShyZXZp c2lvbiA3NTQ3NTYpCisrKyBjb250YWlubWVudC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTQ1LDcg KzQ1LDYgQEAKIAogI2luY2x1ZGUgImxheW91dHMvZnJlZWxheW91dC5oIgogI2luY2x1ZGUgImxh eW91dHMvYm94bGF5b3V0LmgiCi0jaW5jbHVkZSAid2lkZ2V0cy9wdXNoYnV0dG9uLmgiCiAKIG5h bWVzcGFjZSBQbGFzbWEKIHsKQEAgLTE4MiwyMCArMTgxLDE0IEBACiAKICAgICBpZiAoaXNDb250 YWlubWVudCgpICYmIHR5cGUgPT0gRGVza3RvcENvbnRhaW5tZW50KSB7CiAgICAgICAgIGlmICgh ZC0+dG9vbGJveCkgewotICAgICAgICAgICAgUGxhc21hOjpQdXNoQnV0dG9uICp0b29sID0gbmV3 IFBsYXNtYTo6UHVzaEJ1dHRvbihpMThuKCJBZGQgV2lkZ2V0cyIpKTsKLSAgICAgICAgICAgIHRv b2wtPnJlc2l6ZSh0b29sLT5zaXplSGludCgpKTsKLSAgICAgICAgICAgIGFkZFRvb2xCb3hUb29s KHRvb2wsICJhZGR3aWRnZXRzIik7Ci0gICAgICAgICAgICBjb25uZWN0KHRvb2wsIFNJR05BTChj bGlja2VkKCkpLCB0aGlzLCBTSUdOQUwoc2hvd0FkZFdpZGdldHMoKSkpOworICAgICAgICAgICAg UGxhc21hOjpJY29uICphZGRXaWRnZXRUb29sID0gYWRkVG9vbEJveFRvb2woImFkZHdpZGdldHMi LCAiZWRpdC1hZGQiLCBpMThuKCJBZGQgV2lkZ2V0cyIpKTsKKyAgICAgICAgICAgIGNvbm5lY3Qo YWRkV2lkZ2V0VG9vbCwgU0lHTkFMKGNsaWNrZWQoKSksIHRoaXMsIFNJR05BTChzaG93QWRkV2lk Z2V0cygpKSk7CiAKLSAgICAgICAgICAgIHRvb2wgPSBuZXcgUGxhc21hOjpQdXNoQnV0dG9uKGkx OG4oIlpvb20gSW4iKSk7Ci0gICAgICAgICAgICBjb25uZWN0KHRvb2wsIFNJR05BTChjbGlja2Vk KCkpLCB0aGlzLCBTSUdOQUwoem9vbUluKCkpKTsKLSAgICAgICAgICAgIHRvb2wtPnJlc2l6ZSh0 b29sLT5zaXplSGludCgpKTsKLSAgICAgICAgICAgIGFkZFRvb2xCb3hUb29sKHRvb2wsICJ6b29t SW4iKTsKKyAgICAgICAgICAgIFBsYXNtYTo6SWNvbiAqem9vbUluVG9vbCA9IGFkZFRvb2xCb3hU b29sKCJ6b29tSW4iLCAiem9vbS1pbiIsIGkxOG4oIlpvb20gSW4iKSk7CisgICAgICAgICAgICBj b25uZWN0KHpvb21JblRvb2wsIFNJR05BTChjbGlja2VkKCkpLCB0aGlzLCBTSUdOQUwoem9vbUlu KCkpKTsKIAotICAgICAgICAgICAgdG9vbCA9IG5ldyBQbGFzbWE6OlB1c2hCdXR0b24oaTE4bigi Wm9vbSBPdXQiKSk7Ci0gICAgICAgICAgICBjb25uZWN0KHRvb2wsIFNJR05BTChjbGlja2VkKCkp LCB0aGlzLCBTSUdOQUwoem9vbU91dCgpKSk7Ci0gICAgICAgICAgICB0b29sLT5yZXNpemUodG9v bC0+c2l6ZUhpbnQoKSk7Ci0gICAgICAgICAgICBhZGRUb29sQm94VG9vbCh0b29sLCAiem9vbU91 dCIpOworICAgICAgICAgICAgUGxhc21hOjpJY29uICp6b29tT3V0VG9vbCA9IGFkZFRvb2xCb3hU b29sKCJ6b29tT3V0IiwgInpvb20tb3V0IiwgaTE4bigiWm9vbSBPdXQiKSk7CisgICAgICAgICAg ICBjb25uZWN0KHpvb21PdXRUb29sLCBTSUdOQUwoY2xpY2tlZCgpKSwgdGhpcywgU0lHTkFMKHpv b21PdXQoKSkpOwogICAgICAgICB9CiAgICAgfSBlbHNlIHsKICAgICAgICAgZGVsZXRlIGQtPnRv b2xib3g7CkBAIC04MTQsOSArODA3LDIxIEBACiAgICAgZW1pdCBsYXVuY2hBY3RpdmF0ZWQoKTsK IH0KIAotdm9pZCBDb250YWlubWVudDo6YWRkVG9vbEJveFRvb2woUUdyYXBoaWNzSXRlbSAqdG9v bCwgY29uc3QgUVN0cmluZyYgdG9vbE5hbWUpCitQbGFzbWE6Okljb24gKiBDb250YWlubWVudDo6 YWRkVG9vbEJveFRvb2woY29uc3QgUVN0cmluZyYgdG9vbE5hbWUsIGNvbnN0IFFTdHJpbmcmIGlj b25OYW1lLCBjb25zdCBRU3RyaW5nJiBpY29uVGV4dCkKIHsKKyAgICBQbGFzbWE6Okljb24gKnRv b2wgPSBuZXcgUGxhc21hOjpJY29uKHRoaXMpOworCisgICAgdG9vbC0+c2V0SWNvbihLSWNvbihp Y29uTmFtZSkpOworICAgIHRvb2wtPnNldFRleHQoaWNvblRleHQpOworICAgIHRvb2wtPnNldE9y aWVudGF0aW9uKFF0OjpIb3Jpem9udGFsKTsKKyAgICBRU2l6ZUYgaWNvblNpemUgPSB0b29sLT5z aXplRnJvbUljb25TaXplKDIyKTsKKyAgICB0b29sLT5zZXRNaW5pbXVtU2l6ZShpY29uU2l6ZSk7 CisgICAgdG9vbC0+c2V0TWF4aW11bVNpemUoaWNvblNpemUpOworICAgIHRvb2wtPnJlc2l6ZSh0 b29sLT5zaXplSGludCgpKTsKKwogICAgIGQtPmNyZWF0ZVRvb2xib3goKS0+YWRkVG9vbCh0b29s LCB0b29sTmFtZSk7CisKKyAgICByZXR1cm4gdG9vbDsKIH0KIAogdm9pZCBDb250YWlubWVudDo6 ZW5hYmxlVG9vbEJveFRvb2woY29uc3QgUVN0cmluZyAmdG9vbG5hbWUsIGJvb2wgZW5hYmxlKQo= ------=_Part_22138_31436027.1199130723040 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Panel-devel mailing list Panel-devel@kde.org https://mail.kde.org/mailman/listinfo/panel-devel ------=_Part_22138_31436027.1199130723040--