[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: [Panel-devel] [PATCH] Smaller toolbox with icons
From:       Alex Merry <alexander.merry () ccc ! ox ! ac ! uk>
Date:       2007-12-28 13:01:50
Message-ID: 20071228130118.GA3695 () typo ! errata
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


On Fri, Dec 28, 2007 at 05:32:23PM +0900, Jason Stubbs wrote:
> One tiny nit-picky thing so no need to repost a patch, but:
> 
> +    tool->setMinimumSize(iconSize);
> +    tool->setMaximumSize(iconSize);
> +    tool->resize(tool->sizeHint());
> 
> Is there any reason to not use iconSize rather than tool->sizeHint() ? I'm 
> guessing that it returns the same value anyway, but looks out of place and 
> begs the eternal question "why is it so?" ;)

Actually, tool->sizeHint() for Plasma::Icon returns the last value
passed to tool->resize().  My approach was to do
tool->resize(tool->sizeFromIconSize(iconSize));

That should work as a replacement for the above three lines.  I think
setMinimumSize and setMaximumSize can be discarded, as there's no
layouts doing anything.

Alex

-- 
KDE: http://www.kde.org
OpenSUSE: http://www.opensuse.org

[Attachment #5 (application/pgp-signature)]

_______________________________________________
Panel-devel mailing list
Panel-devel@kde.org
https://mail.kde.org/mailman/listinfo/panel-devel


[prev in list] [next in list] [prev in thread] [next in thread]