[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: [Panel-devel] [PATCH] Smaller toolbox with icons
From:       "Aaron J. Seigo" <aseigo () kde ! org>
Date:       2007-12-28 1:41:38
Message-ID: 200712271841.38774.aseigo () kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


On Monday 24 December 2007, Craig Duquette wrote:
> I've updated my patch to clean up some sloppy code.
>
> ~Craig
>
> On Dec 24, 2007 7:13 PM, Craig Duquette <cduquette@gmail.com> wrote:
> > That's pretty cool, I was thinking of moving the icons to the arc of
> > the toolbox also. What about this? I've moved the + to the right and
> > the two zoom buttons appear on the bottom of the toolbox. Someone from
> > IRC had a similar idea of moving icons to the two different sides.
> >
> > This patch also contains the non-resizing toolbox code in it. Now the
> > toolbox will be displayed against a white background when zoomed out
> > so I semi-reverted the gradient back to the original. The edge fades
> > to fully invisible when fully expanded. I think it'd be cool to have
> > it fade to invisible on the default view like the original patch..
> >
> > Also any idea on how to do tooltips? There is a function
> > setToolTip(ToolTipData), but I'm really not sure how to construct a
> > 'ToolTipData' thingy..
> >
> > Craig AKA gamma
> >
> > On 12/24/07, Alex Merry <huntedhacker@tiscali.co.uk> wrote:
> > > On Monday 24 Dec 2007, Alex Merry wrote:
> > > > On Sunday 23 Dec 2007, Craig Duquette wrote:
> > > > > This patch replaces the buttons that appear when you hover over the
> > > > > toolbox with nice pretty oxygen icons :D.
> > > >
> > > > I think my preference would be to have the text written to the left
> > > > of the icons, and ideally to have the icons in a quarter-circle
> > > > following the circumference of the toolbox.
> > >
> > > A quarter-circle wouldn't work with text on the left, actually, now I
> > > think about it.  The attachedd patch is the prettier toolbox plus a
> > > diagonal line of icons.
> > >
> > > There's no text yet, so that either needs adding in or some tooltips
> > > are required.
> > >
> > > And if we go with tooltips, we can have a quarter-circle (although I
> > > think text is probably better...)
> > >
> > > Alex
> > >
> > >
> > >
> > > --
> > > KDE: http://www.kde.org
> > > OpenSUSE: http://www.opensuse.org

+       if (tool->data(ToolName).toString() == "addwidgets")
+         x = 25;
+       else
+         x = m_size*2 - 25;

should be

+       if (tool->data(ToolName).toString() == "addwidgets") {
+           x = 25;
+       } else {
+           x = m_size*2 - 25;
+       }

4 space tabs, always with {}s. the kdelibs coding style =)

i like the direction of this. it will need text ... but i do like the icons 
ending up on the arc.. maybe the text can appear outside the arc and the 
icons in the arc.

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Trolltech

[Attachment #5 (application/pgp-signature)]

_______________________________________________
Panel-devel mailing list
Panel-devel@kde.org
https://mail.kde.org/mailman/listinfo/panel-devel


[prev in list] [next in list] [prev in thread] [next in thread]