[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: [Panel-devel] KDE/kdebase/workspace/plasma/applets/kickoff/core
From:       "Aaron J. Seigo" <aseigo () kde ! org>
Date:       2007-12-19 19:58:05
Message-ID: 200712191258.05544.aseigo () kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


On Wednesday 19 December 2007, Alexis Ménard wrote:
> SVN commit 750623 by menard:
>
> Prevent a crash in my case
>
>
>  M  +3 -1      systemmodel.cpp
>
>
> --- trunk/KDE/kdebase/workspace/plasma/applets/kickoff/core/systemmodel.cpp
> #750622:750623 @@ -222,7 +222,8 @@
>
>      if (index.internalId()-1==APPLICATIONS_ROW) {
>          KService::Ptr service =
> KService::serviceByStorageId(d->appsList[index.row()]); -
> +      if (service)
> +      {
>          switch(role)
>          {
>          case Qt::DisplayRole:
> @@ -236,6 +237,7 @@
>          default:
>              return QVariant();
>          }
> +      }

E_BAD_INDENTATION

also ... if there is no service you want to return an empty QVariant. i've 
fixed and will commit.

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Trolltech

[Attachment #5 (application/pgp-signature)]

_______________________________________________
Panel-devel mailing list
Panel-devel@kde.org
https://mail.kde.org/mailman/listinfo/panel-devel


[prev in list] [next in list] [prev in thread] [next in thread]