[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: [Panel-devel] Multithreaded krunner
From:       "Aaron J. Seigo" <aseigo () kde ! org>
Date:       2007-12-10 4:48:43
Message-ID: 200712092148.43797.aseigo () kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


On Sunday 09 December 2007, Ryan Bitanga wrote:
> Ok to commit?

yes, looks good =) ... 

i do have a couple of tiny nitpicks:

please follow the plasma coding style, which says no spaces inside of parens. 
(search for assignQueuePolicy in interface.cpp). pre-increment vs 
post-increment (e.g. m_count) is also preferred, but that is a 
hyper-nitpick ;)

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Trolltech

[Attachment #5 (application/pgp-signature)]

_______________________________________________
Panel-devel mailing list
Panel-devel@kde.org
https://mail.kde.org/mailman/listinfo/panel-devel


[prev in list] [next in list] [prev in thread] [next in thread]