[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: [Panel-devel] containment switching patch
From:       "Aaron J. Seigo" <aseigo () kde ! org>
Date:       2007-11-26 21:15:55
Message-ID: 200711261415.55258.aseigo () kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


On Monday 26 November 2007, Jeremy wrote:
> On Monday 26 November 2007 03:12:43 Aaron J. Seigo wrote:
> > On Sunday 25 November 2007, Jeremy wrote:
> > > I have a patch here that works mostly.  Any input is appreciated.  The
> > > idea is to reparent an applet when it is moved into another containment
> > > (just
> >
> > i think that the addChild call should be moved to Containment::addApplet.
> > this prevents need to call setParentItem, and it also ensures that the
> > applet gets associated with the correct layout.
>
> how could we do that without breaking Widget::Widget on line 101?

what would break? all it does it move the addChild call out of the full 
Containment::addApplet method that loads it from disk and into the new 
Containment::addApplet(Applet* applet) method. it's just rearanging some code 
to make sure that addChild is always called as it must be.

> > > desktop to desktop containment so far, no tricky panel stuff yet).
> > > Anyway,
> >
> > =)
> >
> > > then you can test while zoomed out.  The only thing missing is when you
> > > drop the applet on the new containment, the handle jumps to a
> > > differentt location.
> >
> > we can tackle that next i suppose ...
> >
> > otherwise, looks good..
>
> Should I commit today as it's a bic change (added some methods to the api)?

sure.


-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Trolltech

[Attachment #5 (application/pgp-signature)]

_______________________________________________
Panel-devel mailing list
Panel-devel@kde.org
https://mail.kde.org/mailman/listinfo/panel-devel


[prev in list] [next in list] [prev in thread] [next in thread]