[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: [Panel-devel] engines, applets and timing
From:       "Aaron J. Seigo" <aseigo () kde ! org>
Date:       2007-09-16 16:22:41
Message-ID: 200709161022.41845.aseigo () kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


On Sunday 16 September 2007, Michael Olbrich wrote:
> On Sun, Sep 16, 2007 at 09:36:37AM -0600, Aaron J. Seigo wrote:
> > On Sunday 16 September 2007, Michael Olbrich wrote:
> > > checking the sender is a bit ugly but I didn't feel like writing an
> > > extra slot?
> >
> > except that now you've made it impossible to call disconnectVisualization
> > directly. this part of the patch is wrong.
>
> I don't think you understood that part.
> Calling disconnectVisualization on destroyed() is fine, but calling
> disconnect() in disconnectVisualization when it is called on destroyed()
> is not. It does not do anything but print an ugly warning.
> (sender() != visualization) is currently only false when
> disconnectVisualization is called on destroyed(). When
> disconnectVisualization is called directly sender() is 0 and disconnect
> is called.

ah .. so the goal was to get rid of a warning on the command line. i'm not 
sure if that's worth uglifying the code. it'll also break if we ever call 
disconnectVisualization via a signal other than destroyed(QObject*) =)

i'd prefer the benign warning ...

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Trolltech

[Attachment #5 (application/pgp-signature)]

_______________________________________________
Panel-devel mailing list
Panel-devel@kde.org
https://mail.kde.org/mailman/listinfo/panel-devel


[prev in list] [next in list] [prev in thread] [next in thread]