[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: [Panel-devel] dataengines and timing revisited
From: "Aaron J. Seigo" <aseigo () kde ! org>
Date: 2007-09-01 19:34:31
Message-ID: 200709011334.32006.aseigo () kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/signed)]
On Saturday 01 September 2007, Michael Olbrich wrote:
> On Fri, Aug 31, 2007 at 01:22:47PM -0600, Aaron J. Seigo wrote:
> > On Friday 31 August 2007, Michael Olbrich wrote:
> > > On Wed, Aug 29, 2007 at 08:40:58PM -0600, Aaron J. Seigo wrote:
> > > > - DataContainers are auto-removed appropriately
> > >
> > > This does not work right now. The problem is that disconnectNotify() is
> > > only called for expicit disconnects and not when the receiver is
> > > deleted. Atached is a patch that uses a different method to detect
> > > unused DataContainers.
> > > It also adds the actual deletion of the DataContainer. Currently the
> > > memory is leaking.
> >
> > it should still listen disconnectNotify events: an object may disconnect
> > without being deleted, and i don't trust that the only place that will
> > ever happen is in disconnectSource.
> >
> > having to use invokeMethod (to queue the call for later) shows how ugly
> > this approach is, actually. there is the issue of items calling query()
> > on a source that isn't connected to anything else (and so gets created
> > and then just hangs out), but i'm really not very comfortable with the
> > usage of invokeMethod there.
>
> New patch is attached. Better?
looks good. one small niggle: checkUsage(QObject*) could just be checkUsage().
the QObject in the destroyed() method will be silently discarded and then all
the checkUsage(0)'s just ecome checkUsage().
anyways.. looks good, pls commit =)
--
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43
KDE core developer sponsored by Trolltech
[Attachment #5 (application/pgp-signature)]
_______________________________________________
Panel-devel mailing list
Panel-devel@kde.org
https://mail.kde.org/mailman/listinfo/panel-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic