--===============1895712767==
Content-Type: multipart/signed;
  boundary="nextPart1334201.xZJtdN8cB2";
  protocol="application/pgp-signature";
  micalg=pgp-sha1
Content-Transfer-Encoding: 7bit

--nextPart1334201.xZJtdN8cB2
Content-Type: text/plain;
  charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline

On Friday 31 August 2007, Robert Knight wrote:
> Updated version of the patch attached in response to initial review by
> richmoore.

looks mostly good =3D)

i suppose  BoxLayout::expandingDirections() should really just return=20
d->expandingDirections()... or even better, get rid of=20
Private::expandingDirections and just always use=20
BoxLayout::expandingDirections()?

coding conventions aren't followed. e.g.:

+        if ( isExpanding )   =20
+            sizes[i] =3D perItemSize;     =20
+        else   =20
+            sizes[i] =3D d->size(item->sizeHint());

should be:


+        if (isExpanding) {
+            sizes[i] =3D perItemSize;     =20
+        } else {
+            sizes[i] =3D d->size(item->sizeHint());
+        }

i can't say i'm overly pleased about putting multiple classes in a single f=
ile=20
either, even if they are tiny.

it also references layoutAnimator which doesn't seem to be in the patch. i=
=20
guess you could commit it with that commented out before we move on to the=
=20
animation support you've done?


> - Basic testing with nested layouts.

as in "you've done basic testing" or "you have a basic test you want to com=
mit=20
to svn"?

=2D-=20
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Trolltech

--nextPart1334201.xZJtdN8cB2
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)

iD8DBQBG2Hew1rcusafx20MRAo6mAKCr7fw4iQgCWF3otkqaYu/rNczZuQCgpJXM
cAC0cMtfJmIsT45g4lQDyGI=
=n7/1
-----END PGP SIGNATURE-----

--nextPart1334201.xZJtdN8cB2--

--===============1895712767==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Panel-devel mailing list
Panel-devel@kde.org
https://mail.kde.org/mailman/listinfo/panel-devel

--===============1895712767==--