[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: [Panel-devel] [PATCH] Beginnings of a panel implementation for
From:       "Aaron J. Seigo" <aseigo () kde ! org>
Date:       2007-08-23 16:56:19
Message-ID: 200708231056.19290.aseigo () kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


On Thursday 23 August 2007, Percy Leonhardt wrote:
> On Monday 20 August 2007, Robert Knight wrote:
> > As an aside, HBoxLayout and VBoxLayout are very similar internally.  I
> > think it would be a good idea to try and merge them to avoid bugs
> > arising from duplication.
>
> Talking about bugs in layout, is it okay to commit the following?

if i read the patch correctly (i'm just about to head out the door, so only 
gave it a quick glance) it seems to:

- add margins to the size hint
- correct a c&p error in hboxlayout where it should be adding the width of the 
items to sizes

if so, it looks good and pls commit.

p.s. it's nice to include what a patch does in brief when including it in an 
email; makes the review process a bit quicker, i find...

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Trolltech

[Attachment #5 (application/pgp-signature)]

_______________________________________________
Panel-devel mailing list
Panel-devel@kde.org
https://mail.kde.org/mailman/listinfo/panel-devel


[prev in list] [next in list] [prev in thread] [next in thread]