[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: [Panel-devel] DataEngine and Corona patches
From: "Leo Franchi" <lfranchi () gmail ! com>
Date: 2007-08-08 19:08:45
Message-ID: c5793d500708081208q4f853ca9s530560509523ed85 () mail ! gmail ! com
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
On 8/8/07, Aaron J. Seigo <aseigo@kde.org> wrote:
>
> On Tuesday 07 August 2007, Leo Franchi wrote:
> > any my answer is basically that it managed to stop all Amarok
> dataengines
> > from working.
>
> what are the amarok dataengines doing? more specifically, what are they
> doing
> wrong? ;) sourceRequested *must* make the source if it returns true. in
> fact,
> here is the API documentation for sourceRequested:
>
> * When a source that does not currently exist is requested by the
> * consumer, this method is called to give the DataEngine the
> * opportunity to create one.
> *
> * The name of the data source (e.g. the source parameter passed
> into
> * setData) it must be the same as the name passed to
> sourceRequested
> * otherwise the requesting visualization may not receive notice
> of a
> * data update.
> *
> * @return true if a DataContainer was set up, false otherwise
>
> are your data engines not doing this?
>
> > The change calls d->source, telling it *not* to attempt to
> > create a datasource if it has to, even though we already know that the
> > d->source( source, false ) call fails, because we already tried that.
> this
>
> wrong. sourceRequested may result in the source being created. that's the
> whole point of calling sourceRequested and it returning a bool. if the
> engine
> can't create the source, then it returns false. otherwise, sourceRequested
> creates the source and returns true.
you are, of course, correct. i guess i assumed that it should have
worked like it used to (before this patch).
> patch has *no* side effects that I can see, i have been using it for the
> > last week.
>
> it creates empty DataSources that the engine has already said it can not
> fulfill.
> my second patch adds a Corona::clearApplets() function, so Corona-derived
>
> this one is good, please commit.
done.
--
> Aaron J. Seigo
> humru othro a kohnu se
> GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43
>
> KDE core developer sponsored by Trolltech
>
> _______________________________________________
> Panel-devel mailing list
> Panel-devel@kde.org
> https://mail.kde.org/mailman/listinfo/panel-devel
>
>
>
--
______________________________________________________
Leo Franchi angel666@myrealbox.com
4305 Charlemagne Ct lfranchi@gmail.com
Austin cell: (650) 704 3680
TX, USA home: (650) 329 0125
[Attachment #5 (text/html)]
<br><br><div><span class="gmail_quote">On 8/8/07, <b class="gmail_sendername">Aaron \
J. Seigo</b> <<a href="mailto:aseigo@kde.org">aseigo@kde.org</a>> \
wrote:</span><blockquote class="gmail_quote" style="margin-top: 0; margin-right: 0; \
margin-bottom: 0; margin-left: 0; margin-left: 0.80ex; border-left-color: #cccccc; \
border-left-width: 1px; border-left-style: solid; padding-left: 1ex"> On Tuesday 07 \
August 2007, Leo Franchi wrote:<br>> any my answer is basically that it managed to \
stop all Amarok dataengines<br>> from working.<br><br>what are the amarok \
dataengines doing? more specifically, what are they doing <br>wrong? ;) \
sourceRequested *must* make the source if it returns true. in fact,<br>here is the \
API documentation for \
sourceRequested:<br><br> * When a \
source that does not currently exist is requested by the<br> \
* consumer, this method is called to \
give the DataEngine the<br> * \
opportunity to create one.<br> \
*<br> * The name of the data source \
(e.g. the source parameter passed \
into<br> * setData) it must be the \
same as the name passed to sourceRequested \
<br> * otherwise the requesting \
visualization may not receive notice of \
a<br> * data \
update.<br> \
*<br> * @return true if a \
DataContainer was set up, false otherwise<br><br>are your data engines not doing \
this? <br><br>> The change calls d->source, telling it *not* to attempt \
to<br>> create a datasource if it has to, even though we already know that \
the<br>> d->source( source, false ) call fails, because we already tried that. \
this <br><br>wrong. sourceRequested may result in the source being created. \
that's the<br>whole point of calling sourceRequested and it returning a bool. if \
the engine<br>can't create the source, then it returns false. otherwise, \
sourceRequested <br>creates the source and returns \
true.</blockquote><div><br><br>you are, of course, correct. i \
guess i assumed that it should have worked&nb \
sp;like it used to (before this patch). </div><br><blockquote \
class="gmail_quote" style="margin-top: 0; margin-right: 0; margin-bottom: 0; \
margin-left: 0; margin-left: 0.80ex; border-left-color: #cccccc; border-left-width: \
1px; border-left-style: solid; padding-left: 1ex"> > patch has *no* side effects \
that I can see, i have been using it for the<br>> last week.<br><br>it creates \
empty DataSources that the engine has already said it can \
not<br>fulfill. </blockquote><br><blockquote class="gmail_quote" \
style="margin-top: 0; margin-right: 0; margin-bottom: 0; margin-left: 0; margin-left: \
0.80ex; border-left-color: #cccccc; border-left-width: 1px; border-left-style: solid; \
padding-left: 1ex"> > my second patch adds a Corona::clearApplets() function, so \
Corona-derived<br><br>this one is good, please \
commit.</blockquote><div><br>done. </div><br><blockquote class="gmail_quote" \
style="margin-top: 0; margin-right: 0; margin-bottom: 0; margin-left: 0; margin-left: \
0.80ex; border-left-color: #cccccc; border-left-width: 1px; border-left-style: solid; \
padding-left: 1ex">
--<br>Aaron J. Seigo<br>humru othro a kohnu se<br>GPG Fingerprint: 8B8B 2209 0C6F \
7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43<br><br>KDE core developer sponsored by \
Trolltech<br><br>_______________________________________________ <br>Panel-devel \
mailing list<br><a href="mailto:Panel-devel@kde.org">Panel-devel@kde.org</a><br><a \
href="https://mail.kde.org/mailman/listinfo/panel-devel">https://mail.kde.org/mailman/listinfo/panel-devel</a><br><br><br>
</blockquote></div><br><br clear="all"><br>-- \
<br>______________________________________________________<br>Leo \
Franchi <a \
href="mailto:angel666@myrealbox.com">angel666@myrealbox.com</a><br>4305 Charlemagne \
Ct <a \
href="mailto:lfranchi@gmail.com">lfranchi@gmail.com</a> \
<br>Austin &nbs \
p; \
cell: (650) 704 3680<br>TX, \
USA   \
; home: \
(650) 329 0125
_______________________________________________
Panel-devel mailing list
Panel-devel@kde.org
https://mail.kde.org/mailman/listinfo/panel-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic