--===============1189245336== Content-Type: multipart/signed; boundary="nextPart1374946.v2DQvknLGV"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit --nextPart1374946.v2DQvknLGV Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline On Monday 30 July 2007, Sebastian Sauer wrote: > Aaron J. Seigo wrote: > > On Monday 30 July 2007, Sebastian Sauer wrote: > >> plasma1.patch goes the most easy way to just allow an applet to change > >> the menu. Probably it would be also an idea to just pass a > >> KActionCollection/KAction's and add them to the menu cause that way we > >> arn't limited to a kmenu for the context-stuff > > > > yes, i like the idea of retrieving QActions. a lot. QList > > contextMenuActions() would be ok, except that "contextMenu" implies a > > menu and you are right that this might be used in non-menu UI, but .. i > > think that's ok. there should probably also be a contextMenuComplete() > > signal so that applets that care to can do a cleanup of their actions... > > Patch attached :) looks great; only change i'd make is to only add the separate=20 if !actions.isEmpty()... i'm also not sure this method should be const=20 because the actions may well get created in that method. please commit at=20 your leisure. =2D-=20 Aaron J. Seigo humru othro a kohnu se GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43 KDE core developer sponsored by Trolltech --nextPart1374946.v2DQvknLGV Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (GNU/Linux) iD8DBQBGrnf11rcusafx20MRAp6wAKCFlYDdZaByEDBh4H7LLqZ4lUKBXwCdGxwa Xm6BDOw8RLmoBNN+bC2O6BU= =JY5b -----END PGP SIGNATURE----- --nextPart1374946.v2DQvknLGV-- --===============1189245336== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Panel-devel mailing list Panel-devel@kde.org https://mail.kde.org/mailman/listinfo/panel-devel --===============1189245336==--