[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: [Panel-devel] SVG render size patch
From:       "Aaron J. Seigo" <aseigo () kde ! org>
Date:       2007-05-28 18:51:00
Message-ID: 200705281251.01617.aseigo () kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


On Monday 28 May 2007, Matt Williams wrote:
> 1) When the Svg is rendered, it is always rendered to its native
> resolution. Then, you can scale it up by passing a larger QRectF to

this wasn't a design decision, it's just a plain ol' bug where the difference 
between the svg's size and the size we're going to paint it wasn't taken into 
consideration. this obviously only affects the painting when doing a specific 
element in the svg.

i think your fix is right, though probably it makes more sense to move the 
method to the Private class and call that method from the public api, 
avoiding the Svg* q; member in the private class ...

> 2) The second problem, and the one that must be fixed was likely caused

this fix looks good

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

Full time KDE developer sponsored by Trolltech (http://www.trolltech.com)

[Attachment #5 (application/pgp-signature)]

_______________________________________________
Panel-devel mailing list
Panel-devel@kde.org
https://mail.kde.org/mailman/listinfo/panel-devel


[prev in list] [next in list] [prev in thread] [next in thread]