[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: [Panel-devel] Plugin manager issues
From:       "=?UTF-8?Q?Rafael_Fern=C3=A1ndez_L=C3=B3pez?=" <ereslibre () gmail ! com>
Date:       2007-02-22 5:59:42
Message-ID: 93f85fee0702212159r623c001fse8aa0ee32f4bbd46 () mail ! gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

[Attachment #4 (text/plain)]

2007/2/22, Aaron J. Seigo <aseigo@kde.org>:
>
> On February 21, 2007, Rafael Fernández López wrote:
> > Well, revisiting this code I see this is just crap. If you close that
> > window (still with the unique-applet added to kicker), reopen that
> window,
> > and remove the unique-applet, it won't be added to the list, since
> > PluginManager::self() is another different instance. I have seen
> probably
>
> a) this belongs on panel-devel, not kde-core-devel


 Sorry.

b) any idea why addapplet.cpp was completely reformatted to use tabs instead
> of spaces? this file now has no useful svn log and violates the coding
> style
> for that application.


Right. Changing this since I was the one that screwed indentation up here.

c) PluginManager::self() is a singleton so it's always the same object
>
> d) the reason for this bug seems obvious: populateApplets doesn't add an
> entry
> if it's already on the panel and unique; pluginDestroyed() is connected to
> updateAppletList(), which just call search(QString) which just filters
> applets that are shown (and populateApplets wouldn't have shown it). what
> needs to happen is populateApplets should add all items then call search
> with
> an empty string which will hide uniqueApplets. then when pluginDestroyed()
> is
> called it'll show up again.


Mmmm... I should have dedicated 5 minutes more to reread methods deeply.
Without any doubt that is the reason. I just don't know why I didn't realize
the process is always the same since kicker is always running, and not
different instances.

and please: spaces, not tabs. =)


I do since some time ago... :)


Bye,
Rafael Fernández López.

[Attachment #5 (text/html)]

2007/2/22, Aaron J. Seigo &lt;<a \
href="mailto:aseigo@kde.org">aseigo@kde.org</a>&gt;:<div><span \
class="gmail_quote"></span><blockquote class="gmail_quote" style="border-left: 1px \
solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"> On February \
21, 2007, Rafael Fernández López wrote:<br>&gt; Well, revisiting this code I see \
this is just crap. If you close that<br>&gt; window (still with the unique-applet \
added to kicker), reopen that window,<br>&gt; and remove the unique-applet, it \
won&#39;t be added to the list, since <br>&gt; PluginManager::self() is another \
different instance. I have seen probably<br><br>a) this belongs on panel-devel, not \
kde-core-devel</blockquote><div><br>&nbsp;Sorry.</div><br><blockquote \
class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt \
0pt 0.8ex; padding-left: 1ex;"> b) any idea why addapplet.cpp was completely \
reformatted to use tabs instead<br>of spaces? this file now has no useful svn log and \
violates the coding style<br>for that application.</blockquote><div><br>Right. \
Changing this since I was the one that screwed indentation up here. \
<br></div><br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, \
204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">c) PluginManager::self() is \
a singleton so it&#39;s always the same object<br> <br>d) the reason for this bug \
seems obvious: populateApplets doesn&#39;t add an entry<br>if it&#39;s already on the \
panel and unique; pluginDestroyed() is connected to<br>updateAppletList(), which just \
call search(QString) which just filters <br>applets that are shown (and \
populateApplets wouldn&#39;t have shown it). what<br>needs to happen is \
populateApplets should add all items then call search with<br>an empty string which \
will hide uniqueApplets. then when pluginDestroyed() is <br>called it&#39;ll show up \
again.</blockquote><div><br>Mmmm... I should have dedicated 5 minutes more to reread \
methods deeply. Without any doubt that is the reason. I just don&#39;t know why I \
didn&#39;t realize the process is always the same since kicker is always running, and \
not different instances. <br></div><br><blockquote class="gmail_quote" \
style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; \
padding-left: 1ex;">and please: spaces, not tabs. =)</blockquote><div><br>I do since \
some time ago... :) <br clear="all"></div></div><br><br>Bye,<br>Rafael Fernández \
López.



_______________________________________________
Panel-devel mailing list
Panel-devel@kde.org
https://mail.kde.org/mailman/listinfo/panel-devel


[prev in list] [next in list] [prev in thread] [next in thread]