[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-optimize
Subject:    Re: [PATCH] libkdeinit symbol pruning
From:       David Faure <faure () kde ! org>
Date:       2004-07-18 22:16:59
Message-ID: 200407190016.59987.faure () kde ! org
[Download RAW message or body]

On Sunday 18 July 2004 16:25, Karl Vogel wrote:
> -                appendLines("libkdeinit_${kdeinit}_la_LDFLAGS = -no-undefined \
> -avoid-version \$(all_libraries)\n"); +                \
> appendLines("libkdeinit_${kdeinit}_la_LDFLAGS = \
> -Wl,--version-script=\$(top_srcdir)/admin/kdeinit.map -no-undefined -avoid-version \
> \$(all_libraries)\n");

Looking at kdelibs/kjs/Makefile.am, I think this should read

if include_VERSION_SCRIPT
KDEINIT_VSCRIPT = -Wl,--version-script=$(top_srcdir)/admin/kdeinit.map
endif

libkdeinit_${kdeinit}_la_LDFLAGS = $(KDEINIT_VSCRIPT) -no-undefined -avoid-version \
\$(all_libraries)

so that it doesn't break on compilers without --version-script support.
Can you make am_edit and unsermake patches for the above?
I'm inclined to commit the whole thing afterwards. Hmm, this will break for 
apps currently linking to kdeinit modules (right?), but that's unportable 
anyway, and warned as being unportable by at least unsermake, so if we can 
make it break even on Linux people won't do that anymore :) 
But, hmm, that makes it difficult to commit this while KDE is feature-frozen.
I'll for sure use it locally from now on to see what needs to be fixed.

-- 
David Faure, faure@kde.org, sponsored by Trolltech to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).
_______________________________________________
Kde-optimize mailing list
Kde-optimize@kde.org
https://mail.kde.org/mailman/listinfo/kde-optimize


[prev in list] [next in list] [prev in thread] [next in thread]