[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-multimedia
Subject:    PATCH: removes libmcop threads dependancy
From:       Stefan Westerfeld <stefan () space ! twc ! de>
Date:       2001-07-25 15:57:28
[Download RAW message or body]

Hi!

I've been planning to apply the following patch quite long. It removes the
libmcop dependancy to libpthread. This dependancy causes problems when used
in non-threaded applications. One example is that loading noatun via kdeinit
is broken for quite a few users right now.

It will not break mpeglib mp3 decoding, since artsd remains linked against
libpthread (due to libmcop_mt). The same is valid for using artsdsp with
threaded apps such as xmms (due to explicit libpthread dependancy). So I
expect that it has no negative side effects.

Feedback - especially testresults like "noatun used to be broken when started
from the menu but works with this patch" - highly appreciated.

   Cu... Stefan
-- 
  -* Stefan Westerfeld, stefan@space.twc.de (PGP!), Hamburg/Germany
     KDE Developer, project infos at http://space.twc.de/~stefan/kde *-         

["20010725-mcop-threading.diff" (text/plain)]

? message.patch
Index: Makefile.am
===================================================================
RCS file: /home/kde/kdelibs/arts/mcop/Makefile.am,v
retrieving revision 1.37
diff -u -r1.37 Makefile.am
--- Makefile.am	2001/03/25 14:54:45	1.37
+++ Makefile.am	2001/07/25 15:49:00
@@ -16,8 +16,7 @@
 	 trader_impl.cc dynamicrequest.cc anyref.cc loopback.cc debug.cc \
 	 delayedreturn.cc thread.cc dynamicskeleton.cc
 
-libmcop_la_LIBADD = $(LIBSOCKET) $(LIBPTHREAD) $(USE_THREADS) \
-     $(top_builddir)/libltdl/libltdlc.la
+libmcop_la_LIBADD = $(LIBSOCKET) $(top_builddir)/libltdl/libltdlc.la
 libmcop_la_LDFLAGS = -no-undefined 
 
 artsincludedir = $(includedir)/arts

_______________________________________________
Kde-multimedia mailing list
Kde-multimedia@master.kde.org
http://master.kde.org/mailman/listinfo/kde-multimedia


[prev in list] [next in list] [prev in thread] [next in thread]