--------------Boundary-00=_RIKX7IK3DMZTWT333SBX
Content-Type: text/plain;
  charset="CP 1252"
Content-Transfer-Encoding: 8bit

Here is a version of the patch with a mutex.

On July 22, 2001 06:25 am, Stefan Westerfeld wrote:
>    Hi!
>
> There are two issues with the patch:
>
>  - it doesn't give immediate feedback to the user when messages are
> repeating (i.e. you don't know whether a message is repeating and repeating
> all the time, because you only see the first version of it, until another
> message pops up)
>
>  - it makes the debugging routines non-thread-safe, because it adds static
>    variables
>
> The first is not too important, and it can be corrected later (after
> KDE2.2), if somebody wants to solve this.
>
> The thread safety issue can be solved by adding a mutex, and I think it
> should be done, because I would like to be able to use the debugging
> routines like arts_debug or arts_return_if_fail even in code that doesn't
> run in the main thread.
>
> If you know how to do this, please do and repost the patch, if not, go
> ahead and apply the patch, and I'll add the mutex.
>
>    Cu... Stefan

--------------Boundary-00=_RIKX7IK3DMZTWT333SBX
Content-Type: text/x-diff;
  charset="CP 1252";
  name="message.patch"
Content-Transfer-Encoding: base64
Content-Disposition: attachment; filename="message.patch"

SW5kZXg6IGRlYnVnLmNjCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT0KUkNTIGZpbGU6IC9ob21lL2tkZS9rZGVsaWJzL2Fy
dHMvbWNvcC9kZWJ1Zy5jYyx2CnJldHJpZXZpbmcgcmV2aXNpb24gMS41CmRpZmYgLXUgLXIxLjUg
ZGVidWcuY2MKLS0tIGRlYnVnLmNjCTIwMDEvMDMvMjAgMTI6NTM6MzAJMS41CisrKyBkZWJ1Zy5j
YwkyMDAxLzA3LzIzIDE0OjI2OjUwCkBAIC0yNSw2ICsyNSw3IEBACiAjaW5jbHVkZSA8c3RkYXJn
Lmg+CiAjaW5jbHVkZSA8c3RkaW8uaD4KICNpbmNsdWRlIDxzdHJpbmcuaD4KKyNpbmNsdWRlICJ0
aHJlYWQuaCIKIAogc3RhdGljIGludCBhcnRzX2RlYnVnX2xldmVsID0gQXJ0czo6RGVidWc6OmxJ
bmZvOwogc3RhdGljIGJvb2wgYXJ0c19kZWJ1Z19hYm9ydCA9IGZhbHNlOwpAQCAtMzksOCArNDAs
OCBAQAogICogYWx3YXlzIHNlbnQgdG8gc3RhbmRhcmQgZXJyb3IgYmVjYXVzZSB0aGV5IHRlbmQg
dG8gYmUgdmVyeSB2ZXJib3NlLgogICogTm90ZSB0aGF0IHRoZSBleHRlcm5hbCBhcHBsaWNhdGlv
biBpcyBydW4gaW4gdGhlIGJhY2tncm91bmQgdG8KICAqIGF2b2lkIGJsb2NraW5nIHRoZSBzb3Vu
ZCBzZXJ2ZXIuCi0qLwotdm9pZCBkaXNwbGF5X21lc3NhZ2UoRGVidWc6OkxldmVsIGxldmVsLCBj
b25zdCBjaGFyICptc2cpIHsKKyAqLwordm9pZCBvdXRwdXRfbWVzc2FnZShEZWJ1Zzo6TGV2ZWwg
bGV2ZWwsIGNvbnN0IGNoYXIgKm1zZykgewogCWNoYXIgYnVmZlsxMDI0XTsKIAogCS8qIGRlZmF1
bHQgdG8gdGV4dCBvdXRwdXQgaWYgbm8gbWVzc2FnZSBhcHAgaXMgZGVmaW5lZCBvciBpZiBpdCBp
cyBhIGRlYnVnIG1lc3NhZ2UuICovCkBAIC02NCw2ICs2NSwzOSBAQAogCQkgIGJyZWFrOyAvLyBh
dm9pZCBjb21waWxlIHdhcm5pbmcKIAl9CiAJc3lzdGVtKGJ1ZmYpOworfQorCisvKgorICogRGlz
cGxheSBhIG1lc3NhZ2UgdXNpbmcgb3V0cHV0X21lc3NhZ2UuIElmIHRoZSBtZXNzYWdlIGlzIHRo
ZSBzYW1lCisgKiBhcyB0aGUgcHJldmlvdXMgb25lLCBqdXN0IGluY3JlbWVudCBhIGNvdW50IGJ1
dCBkb24ndCBkaXNwbGF5CisgKiBpdC4gVGhpcyBwcmV2ZW50cyBmbG9vZGluZyB0aGUgdXNlciB3
aXRoIGR1cGxpY2F0ZSB3YXJuaW5ncy4gSWYgdGhlCisgKiBtZXNzYWdlIGlzIG5vdCB0aGUgc2Ft
ZSBhcyB0aGUgcHJldmlvdXMgb25lLCB0aGVuIHdlIHJlcG9ydCB0aGUKKyAqIHByZXZpb3VzbHkg
cmVwZWF0ZWQgbWVzc2FnZSAoaWYgYW55KSBhbmQgcmVzZXQgdGhlIGxhc3QgbWVzc2FnZSBhbmQK
KyAqIGNvdW50LgorICovCit2b2lkIGRpc3BsYXlfbWVzc2FnZShEZWJ1Zzo6TGV2ZWwgbGV2ZWws
IGNvbnN0IGNoYXIgKm1zZykgeworCXN0YXRpYyBjaGFyIGxhc3RNc2dbMTAyNF07CisJc3RhdGlj
IERlYnVnOjpMZXZlbCBsYXN0TGV2ZWw7CisJc3RhdGljIGludCBtc2dDb3VudCA9IDA7CisJQXJ0
czo6TXV0ZXggbXV0ZXg7CisKKwltdXRleC5sb2NrKCk7CisJaWYgKCFzdHJuY21wKG1zZywgbGFz
dE1zZywgMTAyNCkpCisJeworCQltc2dDb3VudCsrOworCX0gZWxzZSB7CisJCWlmIChtc2dDb3Vu
dCA+IDApCisJCXsKKwkJCWNoYXIgYnVmZlsxMDI0XTsKKwkJCXNwcmludGYoYnVmZiwgIiVzXG4o
VGhlIHByZXZpb3VzIG1lc3NhZ2Ugd2FzIHJlcGVhdGVkICVkIHRpbWVzLikiLCBsYXN0TXNnLCBt
c2dDb3VudCk7CisJCQlvdXRwdXRfbWVzc2FnZShsYXN0TGV2ZWwsIGJ1ZmYpOworCQl9CisJCXN0
cm5jcHkobGFzdE1zZywgbXNnLCAxMDI0KTsKKwkJbGFzdExldmVsID0gbGV2ZWw7CisJCW1zZ0Nv
dW50ID0gMDsKKwkJb3V0cHV0X21lc3NhZ2UobGV2ZWwsIG1zZyk7CisJfQorCW11dGV4LnVubG9j
aygpOwogfQogCiBzdGF0aWMgY2xhc3MgRGVidWdJbml0RnJvbUVudiB7Cg==

--------------Boundary-00=_RIKX7IK3DMZTWT333SBX--
_______________________________________________
Kde-multimedia mailing list
Kde-multimedia@master.kde.org
http://master.kde.org/mailman/listinfo/kde-multimedia