[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-multimedia
Subject:    Re: PATCH: fix for #29008
From:       Nikolas Zimmermann <wildfox () kde ! org>
Date:       2001-07-23 9:13:44
[Download RAW message or body]

On Monday 23 July 2001 00:17, Stefan Westerfeld wrote:
>    Hi!
Hi,
>
> Due to KArtsDispatcher::free() being called before the m_soundServer
> destructor in konq_sound.cc, there is a crash. I think the most reasonable
> way to fix this is to change KArtsDispatcher in a way that ::init and
>
> ::free are replaced by the constructor and destructor.
hm hmm hmm don't like that somehow
>
> That way, you will have to create an instance of KArtsDispatcher, but I
> think this is a good thing anyway, because:
i thought we wanted to avoid that
>
>  - it makes #29008 easy to fix
>  - it ensures that every init is paired with a free if you
>     - create KArtsDispatcher on the stack
> 	- create KArtsDispatcher as member of a class
> 	- use Qt object autodeletion
>  - it works more like the "classic" dispatcher
i didn't want that :) that's why i've made it a Singleton.
>  - we can later put signals into KArtsDispatcher if we need to
if, then else...... do we really need that?
Why?

>
Why not just fix konq_sound??
> Here are the patches.
>
>    Cu... Stefan

-- 
Nikolas Zimmermann
wildfox@kde.org
_______________________________________________
Kde-multimedia mailing list
Kde-multimedia@master.kde.org
http://master.kde.org/mailman/listinfo/kde-multimedia

[prev in list] [next in list] [prev in thread] [next in thread]