[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-multimedia
Subject:    Re: [PATCH] splayplayobject resampling
From:       Nikolas Zimmermann <wildfox () kde ! org>
Date:       2001-07-11 9:22:05
[Download RAW message or body]

On Wednesday 11 July 2001 10:56, Stefan Westerfeld wrote:
>    Hi!
>
> On Wed, Jul 11, 2001 at 01:30:59AM +0200, Stefan Westerfeld wrote:
> > I've finally implemented some resampling code for the SPlayPlayObject.
> > The following works now:
> >
> > % kaboodle http://swr3.mp3.unbn.unit.net:80/
> >
> > [...]
> >  - I hear artefacts caused during decoding, these are not resampling
> > based, because they also occur when playing a 44100 Hz mp3 locally
>
Hi,
> I just spend a little more time debugging this, and found that
> KIOInputStream was causing some problems. It used
> (kdelibs/arts/kde/kioinputstream_impl.cpp):
>

>     QDataStream dataStream(m_data, IO_WriteOnly | IO_Append);
>     dataStream << data;
>
hmmmm
> to concatenate the data sent by the KIO::Job. The problem is that the
> << operator does append
>
>    <the len of the QByteArray as Q_UINT32><the data of the QByteArray>
>
ah, shit, didn't notice that so far
(i mean i couldn't test it since now ;)
> to the stream, which in turn means that the decoder will get the data with
> a lot of numbers in it that don't belong there. I changed this now to
>
>     QDataStream dataStream(m_data, IO_WriteOnly | IO_Append);
>     dataStream.writeRawBytes(data.data(), data.size());
>
> which works a lot better. However, I can still observe occasional hiccups
> although I now have verified that the data that SPlayPlayObject gets is now
> bytewise identical with the original mp3 the server sends.
cool! Thank you very much for this stuff

I am still doing this VideoPlayObject stuff.
I have already converted mpeglib to this (jeesus many classes changed
, always adding stupid function int x11WindowId())

The patch will get posted soon....

Bye
 Bye
  Niko

>
>    Cu... Stefan

-- 
Nikolas Zimmermann
wildfox@kde.org
_______________________________________________
Kde-multimedia mailing list
Kde-multimedia@master.kde.org
http://master.kde.org/mailman/listinfo/kde-multimedia

[prev in list] [next in list] [prev in thread] [next in thread]