[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-multimedia
Subject:    noatun dropouts
From:       "Jeff Tranter" <jefft () corel ! com>
Date:       2001-04-12 17:26:15
[Download RAW message or body]

I'm still seeing a problem that was discussed back in February.
I'm getting dropouts when playing MP3 files with noatun. Its
a fast machine that can play MP3s without problems using
other apps through aRts. If I enable and then disable the
Freeverb Effect then the dropouts go away until artsd is
restarted.

It is hitting the zero filling code demultimedia/mpeglib_artsplug/decoderBaseObject_impl.cpp
If I make the following code hack it works okay.

in Index: decoderBaseObject_impl.cpp
===================================================================
RCS file: /home/kde/kdemultimedia/mpeglib_artsplug/decoderBaseObject_impl.cpp,v
retrieving revision 1.17
diff -u -1 -5 -r1.17 decoderBaseObject_impl.cpp
--- decoderBaseObject_impl.cpp  2000/12/09 16:54:13     1.17
+++ decoderBaseObject_impl.cpp  2001/04/12 17:12:35
@@ -373,31 +373,31 @@
   int audioState=outputStream->waitStreamState(_OUTPUT_WAIT_METHOD_POLL,
                                               _STREAM_MASK_ALL,
                                               _STREAMTYPE_AUDIO);
 
   if (audioState & _STREAM_MASK_IS_INIT) {
     // now check if we already have enough data
     int lenough=false;
     if (audioState & _STREAM_MASK_IS_EOF) {
       if(_state == posPlaying) {
        arts_debug("eof got in arts********** END");
        _state = posIdle;
       }
 
       lenough=true;
     }
-    if (outputStream->getBufferFillgrade() > 8192) {
+    if (outputStream->getBufferFillgrade() >= 0) {
       lenough=true;
     }
     if ( ((lenough) || _blocking) && (_state == posPlaying) ) {
       fillArts(samples,left,right);
       return;
     }
   }
 #endif
 
   // filling with zero , stream not ready(yet)
 
   unsigned int i;
   for(i=0;i<samples;i++)
     left[i] = right[i] = 0.0;
 } 
_______________________________________________
Kde-multimedia mailing list
Kde-multimedia@master.kde.org
http://master.kde.org/mailman/listinfo/kde-multimedia

[prev in list] [next in list] [prev in thread] [next in thread]