[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-multimedia
Subject:    Re: AIX patch: audioioaix.cc
From:       Stefan Westerfeld <stefan () space ! twc ! de>
Date:       2001-04-02 19:49:44
[Download RAW message or body]

   Hi!

On Sun, Apr 01, 2001 at 11:40:23AM +0200, Carsten Griwodz wrote:
> I wanted noise on my AIX box and added an audioioaix file. Any takers?
> The patch adds a new file and puts it into arts/flow/Makefile.am.

Great, thanks. ;) Your code is in the CVS now. I reformatted it a bit to
fit better to the other aRts sources (1 tab = 4 spaces). Other than that,
it looks pretty good. The only two things that you might want to check are:

1. If the user uses artsd -b16 to explicitely set 16bit audio, then your
AudioIOAIX class /might/ (if that is convenient) change this to the format
16 or 17 as needed - AudioIOOSS for instance does this. Since you don't do
the change, I think artsd -b16 might fail on big endian machines (even if
16bit big endian might be supported by the hardware).

2. Full duplex support - artsd will do reading and writing at the same time
if you start it with artsd -d - if AIX supports full duplex, that might be
a nice feature to have.

   Cu... Stefan
-- 
  -* Stefan Westerfeld, stefan@space.twc.de (PGP!), Hamburg/Germany
     KDE Developer, project infos at http://space.twc.de/~stefan/kde *-         
_______________________________________________
Kde-multimedia mailing list
Kde-multimedia@master.kde.org
http://master.kde.org/mailman/listinfo/kde-multimedia

[prev in list] [next in list] [prev in thread] [next in thread]