[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-multimedia
Subject:    [PATCH] no objections ?
From:       Martin Vogt <mvogt () rhrk ! uni-kl ! de>
Date:       2000-07-28 11:53:06
[Download RAW message or body]



Hello,


I would like to apply this patch to kcontrol/arts.

It fixes the bug, that you cannot play mp3s 
without dropouts (when open/close windows)

Any Objections?


Martin


diff -ru arts/arts.cpp /tmp/neu/arts/arts.cpp
--- arts/arts.cpp	Tue Jul 25 00:15:40 2000
+++ /tmp/neu/arts/arts.cpp	Fri Jul 28 10:02:48 2000
@@ -116,9 +116,10 @@
     responseButton[0] = new QRadioButton( i18n("&Fast (10ms)"), responseGroup );
     responseButton[1] = new QRadioButton( i18n("&Standard (50ms)"), responseGroup );
     responseButton[2] = new QRadioButton( i18n("&Comfortable (250ms)"), responseGroup);
+    responseButton[3] = new QRadioButton( i18n("&Playback (1000ms)"), responseGroup);
     //connect(style_group, SIGNAL(clicked(int)), SLOT(style_clicked(int)));
 
-    for (int i = 0; i < 3; i++)
+    for (int i = 0; i < 4; i++)
     vbox->addWidget(responseButton[i]);
     layout->addWidget(responseGroup);
 
@@ -147,9 +148,9 @@
     networkTransparent->setChecked(config->readBoolEntry("NetworkTransparent",false));
     x11Comm->setChecked(config->readBoolEntry("X11GlobalComm",false));
     fullDuplex->setChecked(config->readBoolEntry("FullDuplex",false));
-    for(int i=0;i<3;i++)
+    for(int i=0;i<4;i++)
     {
-        if(config->readNumEntry("ResponseTime",1) == i)
+        if(config->readNumEntry("ResponseTime",3) == i)
             responseButton[i]->setChecked(true);
     }
     updateWidgets();
@@ -163,7 +164,7 @@
     config->writeEntry("NetworkTransparent",networkTransparent->isChecked());
     config->writeEntry("X11GlobalComm",x11Comm->isChecked());
     config->writeEntry("FullDuplex",fullDuplex->isChecked());
-    for(int i=0;i<3;i++)
+    for(int i=0;i<4;i++)
     {
         if(responseButton[i]->isChecked())
             config->writeEntry("ResponseTime",i);
@@ -248,7 +249,7 @@
         bool networkTransparent = config->readBoolEntry("NetworkTransparent",false);
         bool x11Comm = config->readBoolEntry("X11GlobalComm",false);
         bool fullDuplex = config->readBoolEntry("FullDuplex",false);
-        int responseTime = config->readNumEntry("ResponseTime",1);
+        int responseTime = config->readNumEntry("ResponseTime",3);
 
         /* put the value of x11Comm into .mcoprc */
         KConfig *X11CommConfig = new KConfig(QDir::homeDirPath()+"/.mcoprc");
@@ -278,14 +279,21 @@
             switch(responseTime)
             {
                 /* 8.7 ms */
-                case 0: cmdline += " -F 3 -S 512";
-                    break;
+                case 0: 
+		  cmdline += " -F 3 -S 512";
+		  break;
                 /* 40 ms */
-                case 1: cmdline += " -F 7 -S 1024";
-                    break;
+                case 1: 
+		  cmdline += " -F 7 -S 1024";
+		  break;
                 /* 255 ms */
-                case 2: cmdline += " -F 11 -S 4096";
-                    break;
+                case 2: 
+		  cmdline += " -F 11 -S 4096";
+		  break;
+                case 3: 
+		  cmdline += " -F 5 -S 8192";
+		  break;
+		  
             }
             system(cmdline);
         }
Only in /tmp/neu/arts/: arts.cpp~
diff -ru arts/arts.h /tmp/neu/arts/arts.h
--- arts/arts.h	Tue Jul 18 00:15:37 2000
+++ /tmp/neu/arts/arts.h	Fri Jul 28 09:54:14 2000
@@ -66,7 +66,7 @@
   QCheckBox *startServer, *startRealtime, *networkTransparent, *x11Comm,
   			*fullDuplex;
   QButtonGroup *responseGroup;
-  QRadioButton *responseButton[3];
+  QRadioButton *responseButton[4];
 
   KConfig *config;
 };
_______________________________________________
Kde-multimedia mailing list
Kde-multimedia@master.kde.org
http://master.kde.org/mailman/listinfo/kde-multimedia

[prev in list] [next in list] [prev in thread] [next in thread]