'Re: Review Request 125357: make_fat32_compatible: Actually remove double quotes'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-multimedia
Subject:    Re: Review Request 125357: make_fat32_compatible: Actually remove double quotes
From:       "Albert Astals Cid" <aacid () kde ! org>
Date:       2015-12-20 18:56:47
Message-ID: 20151220185647.25463.14601 () mimi ! kde ! org
[Download RAW message or body]

--===============7186837058892803239==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

> On des. 20, 2015, 7:58 a.m., Christian Ehrlicher wrote:
> > Ship It!

Ian doesn't have a commited account, Christian please commit it yourself in his \
behalf.

- Albert

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125357/#review89759
-----------------------------------------------------------

On des. 19, 2015, 8:22 p.m., Ian Schwarz wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125357/
> -----------------------------------------------------------
> 
> (Updated des. 19, 2015, 8:22 p.m.)
> 
> 
> Review request for KDE Multimedia and Marco Nelles.
> 
> 
> Repository: audex
> 
> 
> Description
> -------
> 
> The encoding process fails whenever the option to produce FAT32 compatible \
> filenames is enabled and a song title contains one or more double quotes. 
> 
> Diffs
> -----
> 
> utils/patternparser.cpp 40c3acc 
> 
> Diff: https://git.reviewboard.kde.org/r/125357/diff/
> 
> 
> Testing
> -------
> 
> Compiles and fixes the problem.
> 
> 
> Thanks,
> 
> Ian Schwarz
> 
> 

--===============7186837058892803239==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/125357/">https://git.reviewboard.kde.org/r/125357/</a>
  </td>
    </tr>
   </table>
   <br />

<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <p style="margin-top: 0;">On desembre 20th, 2015, 7:58 a.m. UTC, \
<b>Christian Ehrlicher</b> wrote:</p>  <blockquote style="margin-left: 1em; \
border-left: 2px solid #d0d0d0; padding-left: 10px;">  <pre style="white-space: \
pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: \
-o-pre-wrap; word-wrap: break-word;">Ship It!</pre>  </blockquote>

</blockquote>

<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Ian \
doesn't have a commited account, Christian please commit it yourself in his \
behalf.</p></pre> <br />

<p>- Albert</p>

<br />
<p>On desembre 19th, 2015, 8:22 p.m. UTC, Ian Schwarz wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for KDE Multimedia and Marco Nelles.</div>
<div>By Ian Schwarz.</div>

<p style="color: grey;"><i>Updated des. 19, 2015, 8:22 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
audex
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">The encoding process fails whenever the option to \
produce FAT32 compatible filenames is enabled and a song title contains one or more \
double quotes.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Compiles and fixes the problem.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>utils/patternparser.cpp <span style="color: grey">(40c3acc)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/125357/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============7186837058892803239==--

[Attachment #3 (text/plain)]

_______________________________________________
kde-multimedia mailing list
kde-multimedia@kde.org
https://mail.kde.org/mailman/listinfo/kde-multimedia

[prev in list] [next in list] [prev in thread] [next in thread] 