[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-multimedia
Subject: Re: Review Request 123232: Use CMAKE_INSTALL_FULL_DATAROOTDIR
From: "Andreas Hartmetz" <ahartmetz () gmail ! com>
Date: 2015-04-10 1:03:16
Message-ID: 20150410010316.29217.99172 () mimi ! kde ! org
[Download RAW message or body]
--===============2881976601324528953==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
> On April 9, 2015, 6:40 nachm., Andreas Hartmetz wrote:
> > This commit still breaks the build for me. I just updated and recompiled. \
> > phonon-vlc didn't compile because CMAKE_INSTALL_DATAROOTDIR was undefined in \
> > phonon, which produced a broken PhononConfig.cmake with:
> > set(PHONON_BUILDSYSTEM_DIR "/share/phonon/buildsystem/")
...now fixed again with commit d23f0ade0168eba6ef5f6fd52b1476d48e567bfc.
- Andreas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123232/#review78719
-----------------------------------------------------------
On April 9, 2015, 4:04 nachm., Heiko Becker wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123232/
> -----------------------------------------------------------
>
> (Updated April 9, 2015, 4:04 nachm.)
>
>
> Review request for Phonon.
>
>
> Repository: phonon
>
>
> Description
> -------
>
> This allows installing the architecture independent data outside
> the prefix, for example on a multiarch layout where the prefix
> is /usr/{host-triplet}.
>
>
> Diffs
> -----
>
> cmake/FindPhononInternal.cmake 44862b5
>
> Diff: https://git.reviewboard.kde.org/r/123232/diff/
>
>
> Testing
> -------
>
> Built, installed it and also built phonon-vlc against it.
>
>
> Thanks,
>
> Heiko Becker
>
>
--===============2881976601324528953==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/123232/">https://git.reviewboard.kde.org/r/123232/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On April 9th, 2015, 6:40 nachm. UTC, <b>Andreas \
Hartmetz</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This commit still breaks the build for me. I just \
updated and recompiled. phonon-vlc didn't compile because CMAKE_INSTALL_DATAROOTDIR \
was undefined in phonon, which produced a broken PhononConfig.cmake with:</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">set(PHONON_BUILDSYSTEM_DIR "/share/phonon/buildsystem/")</p></pre> \
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">...now fixed again with commit \
d23f0ade0168eba6ef5f6fd52b1476d48e567bfc.</p></pre> <br />
<p>- Andreas</p>
<br />
<p>On April 9th, 2015, 4:04 nachm. UTC, Heiko Becker wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Phonon.</div>
<div>By Heiko Becker.</div>
<p style="color: grey;"><i>Updated April 9, 2015, 4:04 nachm.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
phonon
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This allows installing the architecture independent data outside the \
prefix, for example on a multiarch layout where the prefix is \
/usr/{host-triplet}.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Built, installed it and also built phonon-vlc against it.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>cmake/FindPhononInternal.cmake <span style="color: grey">(44862b5)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/123232/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============2881976601324528953==--
[Attachment #3 (text/plain)]
_______________________________________________
kde-multimedia mailing list
kde-multimedia@kde.org
https://mail.kde.org/mailman/listinfo/kde-multimedia
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic