From kde-multimedia Sun Oct 19 21:18:36 2014 From: "Raphael Kubo da Costa" Date: Sun, 19 Oct 2014 21:18:36 +0000 To: kde-multimedia Subject: Review Request 120664: Revert "clang compat fix (from Qt)" Message-Id: <20141019211836.18178.29037 () probe ! kde ! org> X-MARC-Message: https://marc.info/?l=kde-multimedia&m=141375354729840 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============6782878629575907906==" --===============6782878629575907906== Content-Type: multipart/alternative; boundary="===============2470919501686563360==" --===============2470919501686563360== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120664/ ----------------------------------------------------------- Review request for Phonon. Repository: phonon Description ------- The original Qt commit (3cba3745, "Phonon: Export ObjectDescriptionModel to prevent link errors with Clang") was a workaround for http://llvm.org/bugs/show_bug.cgi?id=8177, which was fixed more than 4 years ago. Now that we have proper support for clang in Phonon and build it with -fvisibility=hidden, the workaround started causing problems, as ObjectDescriptionModel::staticObject and others were not being exported as expected. A quick test for this is building Qt's phonon capabilities example. This reverts commit 845e395ab3aba10dbd57207ad71fbbd6b422f107. Diffs ----- phonon/objectdescriptionmodel.h 74339b5e64ee1ee48b8b2f783157b566a7f5c3f1 Diff: https://git.reviewboard.kde.org/r/120664/diff/ Testing ------- Built Qt4's examples/phonon/capabilities successfully. Thanks, Raphael Kubo da Costa --===============2470919501686563360== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120664/

Review request for Phonon.

By Raphael Kubo da Costa.

Repository: phonon

Description

The original Qt commit (3cba3745, "Phonon: Export ObjectDescriptionModel to prevent link errors with Clang") was a workaround for http://llvm.org/bugs/show_bug.cgi?id=8177, which was fixed more than 4 years ago.

Now that we have proper support for clang in Phonon and build it with -fvisibility=hidden, the workaround started causing problems, as ObjectDescriptionModel::staticObject and others were not being exported as expected. A quick test for this is building Qt's phonon capabilities example.

This reverts commit 845e395ab3aba10dbd57207ad71fbbd6b422f107.

Testing

Built Qt4's examples/phonon/capabilities successfully.

Diffs

phonon/objectdescriptionmodel.h (74339b5e64ee1ee48b8b2f783157b566a7f5c3f1)

View Diff

--===============2470919501686563360==-- --===============6782878629575907906== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ kde-multimedia mailing list kde-multimedia@kde.org https://mail.kde.org/mailman/listinfo/kde-multimedia --===============6782878629575907906==--