'Re: Review Request 118545: ffmpegthumbs: Port to Frameworks'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-multimedia
Subject:    Re: Review Request 118545: ffmpegthumbs: Port to Frameworks
From:       "Hrvoje Senjan" <hrvoje.senjan () gmail ! com>
Date:       2014-09-15 11:45:01
Message-ID: 20140915114501.22585.31920 () probe ! kde ! org
[Download RAW message or body]

--===============3319886379743625720==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118545/
-----------------------------------------------------------

(Updated Sept. 15, 2014, 11:45 a.m.)

Status
------

This change has been marked as submitted.

Review request for KDE Multimedia and David Faure.

Repository: ffmpegthumbs

Description
-------

simple port to KF5.
added Alex if he maybe has an idea why video/* doesn't seem to work.

Diffs
-----

  CMakeLists.txt dd0974f 
  ffmpegthumbnailer.cpp 03a40c3 
  ffmpegthumbnailer/imagewriter.cpp 7dae371 
  ffmpegthumbnailer/moviedecoder.cpp d63cd4b 
  tests/CMakeLists.txt 5525e00 

Diff: https://git.reviewboard.kde.org/r/118545/diff/

Testing
-------

Builds; thumbnails appear in Dolphin.

Thanks,

Hrvoje Senjan

--===============3319886379743625720==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/118545/">https://git.reviewboard.kde.org/r/118545/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for KDE Multimedia and David Faure.</div>
<div>By Hrvoje Senjan.</div>

<p style="color: grey;"><i>Updated Sept. 15, 2014, 11:45 a.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
ffmpegthumbs
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">simple port to KF5.<br style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" /> \
added Alex if he maybe has an idea why video/* doesn't seem to work.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Builds; thumbnails appear in Dolphin.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>CMakeLists.txt <span style="color: grey">(dd0974f)</span></li>

 <li>ffmpegthumbnailer.cpp <span style="color: grey">(03a40c3)</span></li>

 <li>ffmpegthumbnailer/imagewriter.cpp <span style="color: \
grey">(7dae371)</span></li>

 <li>ffmpegthumbnailer/moviedecoder.cpp <span style="color: \
grey">(d63cd4b)</span></li>

 <li>tests/CMakeLists.txt <span style="color: grey">(5525e00)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/118545/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============3319886379743625720==--

_______________________________________________
kde-multimedia mailing list
kde-multimedia@kde.org
https://mail.kde.org/mailman/listinfo/kde-multimedia

[prev in list] [next in list] [prev in thread] [next in thread] 