From kde-multimedia Mon Sep 15 11:07:22 2014 From: "David Faure" Date: Mon, 15 Sep 2014 11:07:22 +0000 To: kde-multimedia Subject: Re: Review Request 118545: ffmpegthumbs: Port to Frameworks Message-Id: <20140915110722.22584.45272 () probe ! kde ! org> X-MARC-Message: https://marc.info/?l=kde-multimedia&m=141077927030538 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============7464112735763487128==" --===============7464112735763487128== Content-Type: multipart/alternative; boundary="===============3447541137998069904==" --===============3447541137998069904== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118545/#review66540 ----------------------------------------------------------- ffmpegthumbnailer/moviedecoder.cpp Yes, forget about the QtCore/ prefix, that was a Qt4 experiment gone wrong (cf QtGui/QLabel vs QtWidgets/QLabel). - David Faure On Sept. 14, 2014, 9:46 p.m., Hrvoje Senjan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118545/ > ----------------------------------------------------------- > > (Updated Sept. 14, 2014, 9:46 p.m.) > > > Review request for KDE Multimedia and David Faure. > > > Repository: ffmpegthumbs > > > Description > ------- > > simple port to KF5. > added Alex if he maybe has an idea why video/* doesn't seem to work. > > > Diffs > ----- > > CMakeLists.txt dd0974f > ffmpegthumbnailer.cpp 03a40c3 > ffmpegthumbnailer/imagewriter.cpp 7dae371 > ffmpegthumbnailer/moviedecoder.cpp d63cd4b > tests/CMakeLists.txt 5525e00 > > Diff: https://git.reviewboard.kde.org/r/118545/diff/ > > > Testing > ------- > > Builds; thumbnails appear in Dolphin. > > > Thanks, > > Hrvoje Senjan > > --===============3447541137998069904== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118545/

ffmpegthumbnailer/moviedecoder.cpp (Diff revision 2)
19 
#include <kdebug.h>
 19 
#include <qdebug.h>
 
Yes, forget about the QtCore/ prefix, that was a Qt4 experiment gone wrong (cf QtGui/QLabel vs QtWidgets/QLabel).

- David Faure


On September 14th, 2014, 9:46 p.m. UTC, Hrvoje Senjan wrote:

Review request for KDE Multimedia and David Faure.
By Hrvoje Senjan.

Updated Sept. 14, 2014, 9:46 p.m.

Repository: ffmpegthumbs

Description 

simple port to KF5.

added Alex if he maybe has an idea why video/* doesn't seem to work.

Testing 

Builds; thumbnails appear in Dolphin.

Diffs

  • CMakeLists.txt (dd0974f)
  • ffmpegthumbnailer.cpp (03a40c3)
  • ffmpegthumbnailer/imagewriter.cpp (7dae371)
  • ffmpegthumbnailer/moviedecoder.cpp (d63cd4b)
  • tests/CMakeLists.txt (5525e00)

View Diff
--===============3447541137998069904==-- --===============7464112735763487128== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ kde-multimedia mailing list kde-multimedia@kde.org https://mail.kde.org/mailman/listinfo/kde-multimedia --===============7464112735763487128==--