--===============6722345318208318351== Content-Type: multipart/alternative; boundary="===============6436703019216078764==" --===============6436703019216078764== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118545/#review65809 ----------------------------------------------------------- Looks good, thanks! CMakeLists.txt Use (BUILD_TESTING) You might also have to port tests/CMakeLists.txt ffmpegthumbnailer.cpp Unused include ffmpegthumbnailer/imagewriter.cpp Unused include ffmpegthumbnailer/moviedecoder.cpp #include or #include I don't know what the official guideline is. - Maarten De Meyer On Sept. 4, 2014, 6 p.m., Hrvoje Senjan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118545/ > ----------------------------------------------------------- > > (Updated Sept. 4, 2014, 6 p.m.) > > > Review request for KDE Multimedia and David Faure. > > > Repository: ffmpegthumbs > > > Description > ------- > > simple port to KF5. > added Alex if he maybe has an idea why video/* doesn't seem to work. > > > Diffs > ----- > > ffmpegthumbnailer/moviedecoder.cpp d63cd4b > ffmpegthumbnailer/imagewriter.cpp 7dae371 > CMakeLists.txt dd0974f > ffmpegthumbnailer.cpp 03a40c3 > > Diff: https://git.reviewboard.kde.org/r/118545/diff/ > > > Testing > ------- > > Builds; thumbnails appear in Dolphin. > > > Thanks, > > Hrvoje Senjan > > --===============6436703019216078764== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118545/ 

Looks good, thanks!

CMakeLists.txt (Diff revision 2)
38 
if (KDE4_BUILD_TESTS)
 47 
if (KDE4_BUILD_TESTS)
 
Use (BUILD_TESTING)

You might also have to port tests/CMakeLists.txt

ffmpegthumbnailer.cpp (Diff revision 2)
18 
#include <kdebug.h>
 18 
#include <qdebug.h>
 
Unused include

ffmpegthumbnailer/imagewriter.cpp (Diff revision 2)
18 
#include <kdebug.h>
 18 
#include <qdebug.h>
 
Unused include

ffmpegthumbnailer/moviedecoder.cpp (Diff revision 2)
19 
#include <kdebug.h>
 19 
#include <qdebug.h>
 
include <QDebug>


or #include <QtCore/QDebug> I don't know what the official guideline is.

- Maarten De Meyer


On September 4th, 2014, 6 p.m. UTC, Hrvoje Senjan wrote:

Review request for KDE Multimedia and David Faure.
By Hrvoje Senjan.

Updated Sept. 4, 2014, 6 p.m.

Repository: ffmpegthumbs

Description 

simple port to KF5.

added Alex if he maybe has an idea why video/* doesn't seem to work.

Testing 

Builds; thumbnails appear in Dolphin.

Diffs

  • ffmpegthumbnailer/moviedecoder.cpp (d63cd4b)
  • ffmpegthumbnailer/imagewriter.cpp (7dae371)
  • CMakeLists.txt (dd0974f)
  • ffmpegthumbnailer.cpp (03a40c3)

View Diff
--===============6436703019216078764==-- --===============6722345318208318351== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ kde-multimedia mailing list kde-multimedia@kde.org https://mail.kde.org/mailman/listinfo/kde-multimedia --===============6722345318208318351==--