From kde-multimedia Thu Sep 04 18:00:46 2014 From: "Hrvoje Senjan" Date: Thu, 04 Sep 2014 18:00:46 +0000 To: kde-multimedia Subject: Re: Review Request 118545: ffmpegthumbs: Port to Frameworks Message-Id: <20140904180046.11808.78528 () probe ! kde ! org> X-MARC-Message: https://marc.info/?l=kde-multimedia&m=140985369016888 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============3293929722973309089==" --===============3293929722973309089== Content-Type: multipart/alternative; boundary="===============6757456040502288238==" --===============6757456040502288238== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118545/ ----------------------------------------------------------- (Updated Sept. 4, 2014, 8 p.m.) Review request for KDE Multimedia and David Faure. Changes ------- drop the desktop workaround; added dependant review (Maarten reminded me on this review, and found the issue before me) Repository: ffmpegthumbs Description (updated) ------- simple port to KF5. added Alex if he maybe has an idea why video/* doesn't seem to work. Diffs (updated) ----- ffmpegthumbnailer/moviedecoder.cpp d63cd4b ffmpegthumbnailer/imagewriter.cpp 7dae371 CMakeLists.txt dd0974f ffmpegthumbnailer.cpp 03a40c3 Diff: https://git.reviewboard.kde.org/r/118545/diff/ Testing ------- Builds; thumbnails appear in Dolphin. Thanks, Hrvoje Senjan --===============6757456040502288238== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118545/

Review request for KDE Multimedia and David Faure.
By Hrvoje Senjan.

Updated Sept. 4, 2014, 8 p.m.

Changes

drop the desktop workaround; added dependant review (Maarten reminded me on this review, and found the issue before me)
Repository: ffmpegthumbs

Description (updated)

simple port to KF5.

added Alex if he maybe has an idea why video/* doesn't seem to work.

Testing 

Builds; thumbnails appear in Dolphin.

Diffs (updated)

  • ffmpegthumbnailer/moviedecoder.cpp (d63cd4b)
  • ffmpegthumbnailer/imagewriter.cpp (7dae371)
  • CMakeLists.txt (dd0974f)
  • ffmpegthumbnailer.cpp (03a40c3)

View Diff
--===============6757456040502288238==-- --===============3293929722973309089== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ kde-multimedia mailing list kde-multimedia@kde.org https://mail.kde.org/mailman/listinfo/kde-multimedia --===============3293929722973309089==--