[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-multimedia
Subject: Re: Review Request 110645: KMix: improve the appearance of the "Select Master Channel" dialogue
From: "Jonathan Marten" <jjm () keelhaul ! me ! uk>
Date: 2014-08-10 11:02:08
Message-ID: 20140810110208.12259.55525 () probe ! kde ! org
[Download RAW message or body]
--===============1001514043059990169==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/110645/
-----------------------------------------------------------
(Updated Aug. 10, 2014, 11:02 a.m.)
Status
------
This change has been marked as submitted.
Review request for KDE Multimedia.
Repository: kmix
Description
-------
The current dialogue, with its scolling list of radio buttons, does not look good and \
is not consistent with the channel lists as displayed elsewhere in KMix. The buttons \
have no margin, the scrolling list is the same colour as the background, and there \
are no icons for visual cues.
This change displays the channels as a list, in the same way as the "Configure \
Channels" dialogue. The current master channel shown by the highlighted item.
As an added bonus, the widget structure and code is simpler.
Diffs
-----
gui/dialogselectmaster.h b79b56a
gui/dialogselectmaster.cpp a5e5f45
Diff: https://git.reviewboard.kde.org/r/110645/diff/
Testing
-------
Build KMix with these changes, checked appearance and operation of the dialogue with \
2 different sound cards.
File Attachments
----------------
Screen shot - before
https://git.reviewboard.kde.org/media/uploaded/files/2013/05/25/kmix-selectmaster-before.png
Screen shot - after
https://git.reviewboard.kde.org/media/uploaded/files/2013/05/25/kmix-selectmaster-after.png
Thanks,
Jonathan Marten
--===============1001514043059990169==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/110645/">https://git.reviewboard.kde.org/r/110645/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Multimedia.</div>
<div>By Jonathan Marten.</div>
<p style="color: grey;"><i>Updated Aug. 10, 2014, 11:02 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kmix
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The current dialogue, with its scolling list of radio buttons, does not \
look good and is not consistent with the channel lists as displayed elsewhere in \
KMix. The buttons have no margin, the scrolling list is the same colour as the \
background, and there are no icons for visual cues.
This change displays the channels as a list, in the same way as the "Configure \
Channels" dialogue. The current master channel shown by the highlighted item.
As an added bonus, the widget structure and code is simpler.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Build KMix with these changes, checked appearance and operation of the \
dialogue with 2 different sound cards. </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>gui/dialogselectmaster.h <span style="color: grey">(b79b56a)</span></li>
<li>gui/dialogselectmaster.cpp <span style="color: grey">(a5e5f45)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/110645/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2013/05/25/kmix-selectmaster-before.png">Screen \
shot - before</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2013/05/25/kmix-selectmaster-after.png">Screen \
shot - after</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============1001514043059990169==--
_______________________________________________
kde-multimedia mailing list
kde-multimedia@kde.org
https://mail.kde.org/mailman/listinfo/kde-multimedia
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic