From kde-multimedia Sun Jun 08 19:18:47 2014 From: "Hrvoje Senjan" Date: Sun, 08 Jun 2014 19:18:47 +0000 To: kde-multimedia Subject: Re: Review Request 118545: ffmpegthumbs: Port to Frameworks Message-Id: <20140608191847.2444.16923 () probe ! kde ! org> X-MARC-Message: https://marc.info/?l=kde-multimedia&m=140225515508032 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============2231197181154893160==" --===============2231197181154893160== Content-Type: multipart/alternative; boundary="===============8471591069764117852==" --===============8471591069764117852== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit > On June 5, 2014, 12:58 p.m., David Faure wrote: > > Correct, video/* isn't supported. In any case, how can you be sure that this application will support *ALL* video codecs? > > Hrvoje Senjan wrote: > i cannot - this was used in 4.x version, i've added a few specific ones validated they work. will adjust the review, and remove the /* completely... > > David Faure wrote: > Unless I'm wrong, video/* didn't work in kdelibs4 either. > > (IIRC it worked for ServiceMenus, but not for application desktop files, which have to follow the Desktop Entry Spec). > > Hrvoje Senjan wrote: > maybe it *shouldn't* work with 4.x - but i do have thumbs in 4.x dolphin with such a desktop file ;-) > but then http://api.kde.org/frameworks-api/frameworks5-apidocs/kio/html/classThumbCreator.html has it still wrong (that's why i havent removed video/* completely): > "Note that you can supply a comma-separated list of mimetypes to the MimeTypes entry, naming all mimetypes your ThumbCreator supports. You can also use simple wildcards, like "text/*"." > > David Faure wrote: > ah it's a ThumbCreator, not an app, I see. > > kio/src/widgets/previewjob.cpp still supports video/*, see the variable "groupMimeType" in there. So it should work. You can debug it there if it doesn't :-) > > Martin Tobias Holmedahl Sandsmark wrote: > AFAIK there aren't any video codecs or muxes that ffmpeg doesn't support (especially not any with a known mimetype), so IMHO video/* should stay. so i have no choice =) will try to debug why it doesn't work then - Hrvoje ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118545/#review59312 ----------------------------------------------------------- On June 5, 2014, 12:47 p.m., Hrvoje Senjan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118545/ > ----------------------------------------------------------- > > (Updated June 5, 2014, 12:47 p.m.) > > > Review request for KDE Multimedia and David Faure. > > > Repository: ffmpegthumbs > > > Description > ------- > > simple port to KF5. > added Alex if he maybe has an idea why video/* doesn't seem to work. > > > Diffs > ----- > > ffmpegthumbs.desktop 1e2a95a > ffmpegthumbnailer/imagewriter.cpp 7dae371 > ffmpegthumbnailer/moviedecoder.cpp d63cd4b > ffmpegthumbnailer.cpp 03a40c3 > CMakeLists.txt dd0974f > > Diff: https://git.reviewboard.kde.org/r/118545/diff/ > > > Testing > ------- > > Builds; thumbnails appear in Dolphin. > > > Thanks, > > Hrvoje Senjan > > --===============8471591069764117852== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118545/

On June 5th, 2014, 12:58 p.m. CEST, David Faure wrote:

Correct, video/* isn't supported. In any case, how can you be sure that this application will support *ALL* video codecs?

On June 5th, 2014, 1:05 p.m. CEST, Hrvoje Senjan wrote:

i cannot - this was used in 4.x version, i've added a few specific ones validated they work. will adjust the review, and remove the /* completely...

On June 5th, 2014, 1:21 p.m. CEST, David Faure wrote:

Unless I'm wrong, video/* didn't work in kdelibs4 either.

(IIRC it worked for ServiceMenus, but not for application desktop files, which have to follow the Desktop Entry Spec).

On June 5th, 2014, 5:11 p.m. CEST, Hrvoje Senjan wrote:

maybe it *shouldn't* work with 4.x - but i do have thumbs in 4.x dolphin with such a desktop file ;-)
but then http://api.kde.org/frameworks-api/frameworks5-apidocs/kio/html/classThumbCreator.html has it still wrong (that's why i havent removed video/* completely):
"Note that you can supply a comma-separated list of mimetypes to the MimeTypes entry, naming all mimetypes your ThumbCreator supports. You can also use simple wildcards, like "text/*"."

On June 5th, 2014, 5:18 p.m. CEST, David Faure wrote:

ah it's a ThumbCreator, not an app, I see.

kio/src/widgets/previewjob.cpp still supports video/*, see the variable "groupMimeType" in there. So it should work. You can debug it there if it doesn't :-)

On June 6th, 2014, 4:23 p.m. CEST, Martin Tobias Holmedahl Sandsmark wrote:

AFAIK there aren't any video codecs or muxes that ffmpeg doesn't support (especially not any with a known mimetype), so IMHO video/* should stay.

so i have no choice =) will try to debug why it doesn't work then

- Hrvoje

On June 5th, 2014, 12:47 p.m. CEST, Hrvoje Senjan wrote:

Review request for KDE Multimedia and David Faure.

By Hrvoje Senjan.

Updated June 5, 2014, 12:47 p.m.

Repository: ffmpegthumbs

Description

simple port to KF5.
added Alex if he maybe has an idea why video/* doesn't seem to work.

Testing

Builds; thumbnails appear in Dolphin.

Diffs

ffmpegthumbs.desktop (1e2a95a)
ffmpegthumbnailer/imagewriter.cpp (7dae371)
ffmpegthumbnailer/moviedecoder.cpp (d63cd4b)
ffmpegthumbnailer.cpp (03a40c3)
CMakeLists.txt (dd0974f)

--===============8471591069764117852==-- --===============2231197181154893160== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ kde-multimedia mailing list kde-multimedia@kde.org https://mail.kde.org/mailman/listinfo/kde-multimedia --===============2231197181154893160==--